Merge lp:~renatofilho/ubuntu-filemanager-app/no-hardcoded-icons into lp:ubuntu-filemanager-app
Proposed by
Renato Araujo Oliveira Filho
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Bill Filler | ||||
Approved revision: | 575 | ||||
Merged at revision: | 574 | ||||
Proposed branch: | lp:~renatofilho/ubuntu-filemanager-app/no-hardcoded-icons | ||||
Merge into: | lp:ubuntu-filemanager-app | ||||
Diff against target: |
119 lines (+27/-23) 2 files modified
src/app/qml/ui/FileDetailsPopover.qml (+4/-0) src/app/qml/ui/FolderListPage.qml (+23/-23) |
||||
To merge this branch: | bzr merge lp:~renatofilho/ubuntu-filemanager-app/no-hardcoded-icons | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Approve | |
Ubuntu File Manager Developers | Pending | ||
Review via email: mp+307857@code.launchpad.net |
Commit message
Do not use hardcoded paths for icons.
To post a comment you must log in.
PASSED: Continuous integration, rev:574 /core-apps- jenkins. ubuntu. com/job/ filemanager- app-ci/ 91/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/981/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ filemanager- app-ci/ 91/rebuild
https:/