Ubuntu Document Viewer App

Merge lp:~renatofilho/ubuntu-docviewer-app/mir-libs into lp:ubuntu-docviewer-app

  1. mir-libs
  2. Merge into lo-viewer
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Pat McGowan
Approved revision: 363
Merged at revision: 362
Proposed branch: lp:~renatofilho/ubuntu-docviewer-app/mir-libs
Merge into: lp:ubuntu-docviewer-app
Diff against target: 32 lines (+7/-2)
1 file modified
snapcraft.yaml (+7/-2)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-docviewer-app/mir-libs
Reviewer Review Type Date Requested Status
Pat McGowan Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+320623@code.launchpad.net

Commit message

[snap] Connect with mir-libs content share.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:362
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/278/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1022/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/278/rebuild

review: Approve (continuous-integration)
lp:~renatofilho/ubuntu-docviewer-app/mir-libs updated
362. By Renato Araujo Oliveira Filho

[snap] Connect with mir-libs content share.

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

It needs to set it to
    content: mir0
to match the slot definition.

(even though this works for me with the locally installed snap)

review: Needs Fixing
lp:~renatofilho/ubuntu-docviewer-app/mir-libs updated
363. By Renato Araujo Oliveira Filho

Use correct mir slot name.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:363
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/279/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/1028/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/docviewer-app-ci/279/rebuild

review: Approve (continuous-integration)
Revision history for this message
Pat McGowan (pat-mcgowan) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'snap/mir-libs'
2=== modified file 'snapcraft.yaml'
3--- snapcraft.yaml 2017-02-08 16:20:00 +0000
4+++ snapcraft.yaml 2017-03-23 19:04:28 +0000
5@@ -15,6 +15,7 @@
6 - unity7
7 - unity8
8 - mir
9+ - mir-libs
10
11 plugs:
12 platform:
13@@ -22,6 +23,11 @@
14 content: ubuntu-app-platform1
15 target: ubuntu-app-platform
16 default-provider: ubuntu-app-platform
17+ mir-libs:
18+ interface: content
19+ content: mir0
20+ target: mir-libs
21+ default-provider: mir-libs
22
23 parts:
24 ubuntu-docviewer-app:
25@@ -66,6 +72,5 @@
26
27 platform:
28 plugin: dump
29- source: snap
30+ source: snap/
31 after: [desktop-ubuntu-app-platform]
32- snap: [ubuntu-app-platform]

Subscribers

People subscribed via source and target branches