Merge lp:~renatofilho/ubuntu-clock-app/new-snappy into lp:ubuntu-clock-app

Proposed by Renato Araujo Oliveira Filho on 2016-11-10
Status: Merged
Approved by: Renato Araujo Oliveira Filho on 2016-11-16
Approved revision: 499
Merged at revision: 497
Proposed branch: lp:~renatofilho/ubuntu-clock-app/new-snappy
Merge into: lp:ubuntu-clock-app
Diff against target: 282 lines (+206/-43)
4 files modified
setup/gui/ubuntu-clock-app.desktop (+147/-0)
snap/ubuntu-clock-app.wrapper (+12/-0)
snapcraft.yaml (+47/-41)
snappy-qt5.conf (+0/-2)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-clock-app/new-snappy
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve on 2016-11-16
Alan Pope 🍺🐧🐱 🦄 2016-11-10 Approve on 2016-11-16
Review via email: mp+310585@code.launchpad.net

Commit Message

Make use of 'ubuntu-app-platform' shared content.

To post a comment you must log in.
review: Approve (continuous-integration)
review: Approve (continuous-integration)
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM!

review: Approve

FAILED: Autolanding.
Unapproved changes made after approval.
https://core-apps-jenkins.ubuntu.com/job/clock-app-autolanding/282/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/5795/console

review: Needs Fixing (continuous-integration)
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'setup'
2=== added directory 'setup/gui'
3=== added file 'setup/gui/icon.png'
4Binary files setup/gui/icon.png 1970-01-01 00:00:00 +0000 and setup/gui/icon.png 2016-11-16 13:33:04 +0000 differ
5=== added file 'setup/gui/ubuntu-clock-app.desktop'
6--- setup/gui/ubuntu-clock-app.desktop 1970-01-01 00:00:00 +0000
7+++ setup/gui/ubuntu-clock-app.desktop 2016-11-16 13:33:04 +0000
8@@ -0,0 +1,147 @@
9+[Desktop Entry]
10+Version=1.0
11+Name=Clock
12+Name[aa]=Uddur
13+Name[am]=ሰአት
14+Name[ar]=الساعة
15+Name[ast]=Reló
16+Name[az]=Saat
17+Name[be]=Гадзіннік
18+Name[bg]=Часовник
19+Name[br]=Eurier
20+Name[bs]=Sat
21+Name[ca]=Rellotge
22+Name[ca@valencia]=Rellotge
23+Name[cs]=Hodiny
24+Name[cy]=Cloc
25+Name[da]=Ur
26+Name[de]=Uhr
27+Name[el]=Ρολόι
28+Name[en_AU]=Clock
29+Name[en_GB]=Clock
30+Name[es]=Reloj
31+Name[eu]=Erlojua
32+Name[fa]=ساعت‌
33+Name[fi]=Kello
34+Name[fr]=Horloge
35+Name[fr_CA]=Horloge
36+Name[gd]=Cleoc
37+Name[gl]=Reloxo
38+Name[he]=שעון
39+Name[hu]=Óra
40+Name[id]=Jam
41+Name[it]=Orologio
42+Name[km]=នាឡិកា
43+Name[kn]=ಗಡಿಯಾರ
44+Name[ko]=시계
45+Name[ku]=Demjimêr
46+Name[lv]=Pulkstenis
47+Name[ms]=Jam
48+Name[my]=နာရီ
49+Name[nb]=Klokke
50+Name[nl]=Klok
51+Name[oc]=Relòtge
52+Name[pa]=ਘੜੀ
53+Name[pl]=Zegar
54+Name[pt]=Relógio
55+Name[pt_BR]=Relógio
56+Name[ro]=Ceas
57+Name[ru]=Часы
58+Name[shn]=ဢွမ်မူင်း
59+Name[sk]=Hodiny
60+Name[sl]=Ura
61+Name[sr]=Часовник
62+Name[sv]=Klocka
63+Name[ta]=கடிகாரம்
64+Name[tr]=Saat
65+Name[ug]=سائەت
66+Name[uk]=Годинник
67+Name[zh_CN]=时钟
68+Name[zh_TW]=時鐘
69+Comment=A sophisticated clock app that provides world clock, alarm and stopwatch functionality.
70+Comment[am]=ውስብስብ የ ሰአት መተግበሪያ የ አለም ሰአት: መቀስቀሻ እና ሰአት ማስቆሚያ ተግባሮች ያካትታል
71+Comment[ast]=Una sofisticada app de reló qu'ufre funciones de reló mundial, alarma y cronómetru.
72+Comment[be]=Прасунуты гадзіннік з функцыяй сусветнага часу, будзільнікам і секундамерам.
73+Comment[br]=Un arload horolaj eus ar c'hentañ gant ur montr evit ar bed a-bezh, un alarm hag ur c'hronometr.
74+Comment[bs]=Sofisticirana aplikacija za sat koja pruža pregled svjetskog sata, uz funkcije alarma i štoperice.
75+Comment[cs]=Důmyslná aplikace Hodiny, která nabízí funkci hodin s různými časovými pásmy, budíku a stopek.
76+Comment[cy]=Ap cloc soffistigedig sy'n cynnig cloc y byd, larwm a watsh amseru
77+Comment[da]=En sofistikeret tidsur-app, der tilbyder verdensur, alarmer og stopur.
78+Comment[de]=Eine durchdachte Uhren-App mit den Funktionen Weltzeit, Wecker und Stoppuhr.
79+Comment[el]=Μια εκλεπτισμένη εφαρμογή ρολόι που παρέχει λειτουργίες παγκόσμιου ρολογιού, ξυπνητηριού και χρονομέτρου
80+Comment[en_AU]=A sophisticated clock app that provides world clock, alarm and stopwatch functionality.
81+Comment[en_GB]=A sophisticated clock app that provides world clock, alarm and stopwatch functionality.
82+Comment[es]=Una aplicación sofisticada con reloj mundial, alarmas y cronómetro.
83+Comment[fa]=یک کارهٔ ساعت سطح بالا که قابلیت‌های ساعت جهانی، هشدار و زمان‌سنج را فراهم می‌کند.
84+Comment[fi]=Kellosovellus, joka tarjoaa maailmankellot, hälytyksen ja sekuntikellon.
85+Comment[fr]=Une application sophistiquée qui fournit des fonctionnalités d'horloge mondiale, d'alarme et de chronomètre.
86+Comment[fr_CA]=Une application sophistiquée qui fournit des fonctions d'horloge mondiale, d'alarme et de chronomètre.
87+Comment[gd]=Aplacaid cleoc thapaidh a bheil uaireadair an t-saoghail, caismeachdan agus stad-uaireadair dhut.
88+Comment[gl]=Un aplicativo de reloxo sofisticado que proporciona horas de todo o mundo, alarma e cronómetro.
89+Comment[hu]=Egy óra alkalmazás, mely stopper, ébresztő-, illetve világóra funkciókkal bír.
90+Comment[id]=Aplikasi jam yang lengkap dengan fungsi jam dunia, alarm, dan stopwatch.
91+Comment[it]=Un sofisticato orologio che fornisce l'ora da diversi fusi orari e funzionalità di sveglia e cronometro.
92+Comment[ku]=Sepana demjimêrê ku tê de demjimêra cîhanî, alarm û kronometre heye
93+Comment[lv]=Gudra pulksteņu lietotne, kas sniedz pasaules pulksteņu, atgādinājumu un hronometra funkcionalitāti.
94+Comment[ms]=Apl jam canggih yang menyediakan kefungsian jam dunia, penggera dan jam randik.
95+Comment[nb]=Et avansert klokkeprogram med funksjonalitet for verdens-, vekker- og stoppeklokke.
96+Comment[nl]=Een uitgekiende klok-app die wereldklok-, alarm- en stopwatchfunctionaliteit biedt.
97+Comment[oc]=Una aplicacion sofisticada que prpvesís de foncionalitats de relòtge mondial, d'alarma e de cronomètre.
98+Comment[pl]=Zaawansowany zegar, z czasami miast z całego świata, budzikiem oraz stoperem.
99+Comment[pt]=Uma app que fornece um relógio mundial, alarme e cronómetro.
100+Comment[ru]=Продвинутые часы с функцией мирового времени, будильником и секундомером.
101+Comment[sk]=Sofistikovaná aplikácia Hodiny, ktorá poskytuje svetový čas, budík a stopky.
102+Comment[sl]=Prefinjena ura, ki nudi prikaz svetovnih časov, alarm in štoparico.
103+Comment[sr]=Софистицирана апликација часовника која пружа функције светсог часовника, будилника и штоперице.
104+Comment[sv]=En sofistikerad klockapp med världsur, alarm och tidtagarfunktionalitet.
105+Comment[tr]=Dünya saati, alarm ve kronometre işlevselliği sunan gelişmiş saat uygulaması
106+Comment[uk]=Програма-годинник із розширеними можливостями: часові пояси світу, будильник та секундомір.
107+Comment[zh_CN]=一个完备世界时、闹铃以及计时功能的时钟应用。
108+Keywords=time;alarm;alert;clock;world;stopwatch;
109+Keywords[am]=ሰአት: መቀስቀሻ: ማስጠንቀቂያ: የ አለም ሰአት: ሰአት ማስቆሚያ
110+Keywords[ast]=hora;alarma;alerta;reló;mundial;cronómetru;
111+Keywords[be]=час;будзільнік;паведамленне;гадзіннік;сусветны;секундамер;
112+Keywords[br]=eur,alarm;diwall;horolaj;bed;kronometr;
113+Keywords[bs]=vrijeme;alarm;uzbuna;sat;svijetski;štoperica;
114+Keywords[cs]=čas;budík;upozornění;hodiny;svět;stopky;
115+Keywords[cy]=amser;larwm;rhybudd;cloc;byd;watshamseru;
116+Keywords[da]=tid;alarm;advarsel;ur;verden;stopur;
117+Keywords[de]=Zeit;Uhrzeit;time;alarm;Wecker;Weckzeit;alert;Alarm;Erinnerung;clock;Uhr;world;Welt;Weltzeit;stopwatch;Stoppuhr,Stopuhr,Stopp-Uhr;
118+Keywords[el]=χρόνος;ξυπνητήρι;ειδοποίηση;ρολόι;κόσμος;χρονόμετρο;
119+Keywords[en_AU]=time;alarm;alert;clock;world;stopwatch;
120+Keywords[en_GB]=time;alarm;alert;clock;world;stopwatch;
121+Keywords[es]=hora;alarma;alerta;reloj;mundial;cronómetro;
122+Keywords[fa]=time;alarm;alert;clock;world;stopwatch;
123+Keywords[fi]=time;alarm;alert;clock;world;stopwatch;aika;hälytys;herätys;kello;sekuntikello;
124+Keywords[fr]=heure;alarme;alerte;horloge;monde;chronomètre;
125+Keywords[fr_CA]=heure;alarme;alerte;horloge;monde;mondiale;chronomètre;
126+Keywords[gd]=time;alarm;alert;clock;world;stopwatch;ùine;àm;uair;caismeachd;dùsgadh;saoghal;stad-uaireadair;
127+Keywords[gl]=hora;alarma;alerta;reloxo;mundo;cronómetro;
128+Keywords[hu]=idő;ébresztés;riasztás;óra;világ;stopper;
129+Keywords[id]=time;alarm;alert;clock;world;stopwatch;
130+Keywords[it]=ora;sveglia;allarme;avviso;orologio;cronometro;mondo;
131+Keywords[ku]=dem;alarm;hişyarî;demjimêr;cîhan;kronometre
132+Keywords[lv]=laiks;trauksme;atgādinājums;pulkstenis;pasaule;hronometrs;
133+Keywords[ms]=waktu;penggera;amaran;jam;duni;jamrandik;
134+Keywords[nb]=tid;alarm;varsel;klokke;verden;stoppeklokke;
135+Keywords[nl]=tijd;alarm;alertering;klok;wereld;stopwatch;
136+Keywords[oc]=ora;alarma;alèrta;relòtge;monde;cronomètre;
137+Keywords[pl]=czas;alarm;budzik;alert;zegar;świat;stoper;
138+Keywords[pt]=tempo;alarme;alerta;relógio;mundo;cronómetro;
139+Keywords[ru]=время;будильник;уведомление;часы;мировое;секундомер;
140+Keywords[sk]=čas;budík;výstraha;hodiny;svet;stopky;
141+Keywords[sl]=čas;alarm;bujenje;ura;svetovni;štoparica;
142+Keywords[sr]=време;будилник;упозорење;часовник;свет;штоперица;
143+Keywords[sv]=tid;alarm;varning;klocka;värld;tidtagning;
144+Keywords[tr]=zaman;alarm;uyarı;saat;dünya;kronometre
145+Keywords[uk]=time;alarm;alert;clock;world;stopwatch;час;нагадування;будильник;дзвінок;годинник;світ;секундомір;
146+Keywords[zh_CN]=time;alarm;alert;clock;world;stopwatch; 时间;闹铃;闹钟;世界时;秒表;
147+Keywords[zh_TW]=time;alarm;alert;clock;world;stopwatch;時鐘;鬧鐘;鬧鈴;世界;碼表;
148+Exec=ubuntu-clock-app %u
149+Icon=/snap/ubuntu-clock-app/current/meta/gui/icon.png
150+Terminal=false
151+Type=Application
152+X-Ubuntu-Touch=true
153+X-Ubuntu-Default-Department-ID=accessories
154+X-Ubuntu-Splash-Color=#F5F5F5
155+X-Ubuntu-Supported-Orientations=portrait
156
157=== added directory 'snap'
158=== added directory 'snap/ubuntu-app-platform'
159=== added file 'snap/ubuntu-clock-app.wrapper'
160--- snap/ubuntu-clock-app.wrapper 1970-01-01 00:00:00 +0000
161+++ snap/ubuntu-clock-app.wrapper 2016-11-16 13:33:04 +0000
162@@ -0,0 +1,12 @@
163+#!/bin/bash
164+
165+if [ "$SNAP_ARCH" == "amd64" ]; then
166+ ARCH="x86_64-linux-gnu"
167+elif [ "$SNAP_ARCH" == "armhf" ]; then
168+ ARCH="arm-linux-gnueabihf"
169+else
170+ ARCH="$SNAP_ARCH-linux-gnu"
171+fi
172+
173+export QML2_IMPORT_PATH=$SNAP/usr/lib/$ARCH/qt5/qml/ClockApp:$QML2_IMPORT_PATH
174+exec qmlscene --desktop_file_hint=unity8 $SNAP/usr/share/ubuntu-clock-app/ubuntu-clock-app.qml
175
176=== modified file 'snapcraft.yaml'
177--- snapcraft.yaml 2016-07-14 12:51:10 +0000
178+++ snapcraft.yaml 2016-11-16 13:33:04 +0000
179@@ -1,49 +1,55 @@
180 name: ubuntu-clock-app
181-version: "3.8.480"
182+version: 3.8.480
183 summary: Ubuntu Clock app
184 description: The clock app for all Ubuntu devices
185 confinement: strict
186+grade: devel
187
188 apps:
189- ubuntu-clock-app:
190- command: clock
191- plugs: [unity7, opengl, network, network-bind]
192+ ubuntu-clock-app:
193+ command: desktop-launch $SNAP/bin/ubuntu-clock-app
194+ plugs: [unity7, platform, opengl, network, network-bind]
195+
196+plugs:
197+ platform:
198+ interface: content
199+ content: ubuntu-app-platform1
200+ target: ubuntu-app-platform
201
202 parts:
203- clock:
204- source: .
205- plugin: cmake
206- configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
207- build-packages:
208- - build-essential
209- - cmake
210- - gettext
211- - intltool
212- - ubuntu-touch-sounds
213- - suru-icon-theme
214- - qml-module-qttest
215- - qml-module-qtsysteminfo
216- - qml-module-qt-labs-settings
217- - qtdeclarative5-u1db1.0
218- - qtdeclarative5-qtmultimedia-plugin
219- - qtdeclarative5-qtpositioning-plugin
220- - qtdeclarative5-ubuntu-content1
221- - qt5-default
222- - qtbase5-dev
223- - qtdeclarative5-dev
224- - qtdeclarative5-dev-tools
225- - qtdeclarative5-folderlistmodel-plugin
226- - qtdeclarative5-ubuntu-ui-toolkit-plugin
227- - xvfb
228- stage-packages:
229- - ubuntu-sdk-libs
230- - qtubuntu-desktop
231- - qml-module-qtsysteminfo
232- snap:
233- - -usr/share/doc
234- - -usr/include
235- environment:
236- plugin: copy
237- files:
238- clock.wrapper: bin/clock
239- snappy-qt5.conf: etc/xdg/qtchooser/snappy-qt5.conf
240+ ubuntu-clock-app:
241+ source: .
242+ plugin: cmake
243+ configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
244+ build-packages:
245+ - build-essential
246+ - cmake
247+ - gettext
248+ - intltool
249+ - ubuntu-touch-sounds
250+ - suru-icon-theme
251+ - qml-module-qttest
252+ - qml-module-qtsysteminfo
253+ - qml-module-qt-labs-settings
254+ - qtdeclarative5-u1db1.0
255+ - qtdeclarative5-qtmultimedia-plugin
256+ - qtdeclarative5-qtpositioning-plugin
257+ - qtdeclarative5-ubuntu-content1
258+ - qt5-default
259+ - qtbase5-dev
260+ - qtdeclarative5-dev
261+ - qtdeclarative5-dev-tools
262+ - qtdeclarative5-folderlistmodel-plugin
263+ - qtdeclarative5-ubuntu-ui-toolkit-plugin
264+ - xvfb
265+
266+ snap:
267+ - -usr/share/doc
268+ - -usr/include
269+ after: [desktop-ubuntu-app-platform]
270+
271+ environment:
272+ source: snap/
273+ plugin: dump
274+ organize:
275+ ubuntu-clock-app.wrapper: bin/ubuntu-clock-app
276
277=== removed file 'snappy-qt5.conf'
278--- snappy-qt5.conf 2016-07-13 13:53:40 +0000
279+++ snappy-qt5.conf 1970-01-01 00:00:00 +0000
280@@ -1,2 +0,0 @@
281-./usr/lib/x86_64-linux-gnu/qt5/bin
282-./usr/lib/x86_64-linux-gnu

Subscribers

People subscribed via source and target branches