Merge lp:~renatofilho/ubuntu-calendar-app/snappy-runtime into lp:ubuntu-calendar-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Merged at revision: 895
Proposed branch: lp:~renatofilho/ubuntu-calendar-app/snappy-runtime
Merge into: lp:ubuntu-calendar-app
Diff against target: 110 lines (+10/-63)
3 files modified
setup/gui/ubuntu-calendar-app.desktop (+1/-1)
snapcraft.yaml (+9/-36)
ubuntu-calendar-app.wrapper (+0/-26)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-calendar-app/snappy-runtime
Reviewer Review Type Date Requested Status
Timo Jyrinki Needs Fixing
Review via email: mp+310200@code.launchpad.net
To post a comment you must log in.
900. By Renato Araujo Oliveira Filho

Use new launcher.

901. By Renato Araujo Oliveira Filho

Added 'mir-graphics-drivers-desktop' as deb. (Temporary solution)

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

(mir-graphics-driver-desktop now in platform snap)

review: Needs Fixing
902. By Renato Araujo Oliveira Filho

Update app icon path.
Remove use of wrapper.

903. By Renato Araujo Oliveira Filho

Remove unecessary code from snapcraft.yaml file.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup/gui/ubuntu-calendar-app.desktop'
2--- setup/gui/ubuntu-calendar-app.desktop 2016-09-29 13:53:06 +0000
3+++ setup/gui/ubuntu-calendar-app.desktop 2016-11-11 19:20:32 +0000
4@@ -3,7 +3,7 @@
5 Type=Application
6 Terminal=false
7 Exec=ubuntu-calendar-app %u
8-Icon=/snap/ubuntu-calendar-app/current/calendar-app@30.png
9+Icon=/snap/ubuntu-calendar-app/current/meta/gui/icon.png
10 Name=Calendar
11 Name[aa]=Aysalu
12 Name[am]=የቀን መቁጠሪያ
13
14=== added directory 'snap'
15=== added directory 'snap/ubuntu-app-platform'
16=== modified file 'snapcraft.yaml'
17--- snapcraft.yaml 2016-10-07 14:33:55 +0000
18+++ snapcraft.yaml 2016-11-11 19:20:32 +0000
19@@ -7,15 +7,14 @@
20
21 apps:
22 ubuntu-calendar-app:
23- command: desktop-launch $SNAP/bin/ubuntu-calendar-app --desktop_file_hint=unity8 "$@"
24+ command: desktop-launch qmlscene --desktop_file_hint=unity8 $SNAP/usr/share/calendar-app/calendar.qml
25+ plugs: [home, gsettings, opengl, platform, unity7]
26
27 plugs:
28- gsettings:
29- interface: gsettings
30- unity7:
31- interface: unity7
32- opengl:
33- interface: opengl
34+ platform:
35+ interface: content
36+ content: ubuntu-app-platform1
37+ target: ubuntu-app-platform
38 # eds-calendar and address-book not available yet.
39 # FIXME: Fixt that after these interfaces appear on syncd
40 # eds-calendar:
41@@ -32,35 +31,9 @@
42 build-packages:
43 - cmake
44 - intltool
45- stage-packages:
46- - accountsservice
47- - accountsservice-ubuntu-schemas
48- - account-plugin-google
49- - qmlscene
50- - qml-module-qt-labs-settings
51- - qml-module-qtcontacts
52- - qml-module-qtorganizer
53- - qml-module-ubuntu-components
54- - qml-module-ubuntu-onlineaccounts
55- - qml-module-ubuntu-onlineaccounts-client
56- - qtdeclarative5-ubuntu-content1
57- - qtdeclarative5-ubuntu-syncmonitor0.1
58- - qtcontact5-galera
59- - qtorganizer5-eds
60- - qtubuntu-desktop
61- - suru-icon-theme
62- - mir-graphics-drivers-desktop
63- stage:
64- - -usr/share/pkgconfig/xkeyboard-config.pc
65- - -usr/share/pkgconfig/shared-mime-info.pc
66- snap:
67- - -usr/lib/python3
68- - -usr/share/doc
69- - -usr/include
70- after: [desktop-gtk3]
71+ stage-packages: []
72+ after: [desktop-ubuntu-app-platform]
73
74 environment:
75- source: .
76+ source: snap/
77 plugin: dump
78- organize:
79- ubuntu-calendar-app.wrapper: bin/ubuntu-calendar-app
80
81=== removed file 'ubuntu-calendar-app.wrapper'
82--- ubuntu-calendar-app.wrapper 2016-09-29 14:58:50 +0000
83+++ ubuntu-calendar-app.wrapper 1970-01-01 00:00:00 +0000
84@@ -1,26 +0,0 @@
85-#!/bin/sh
86-
87-if [ "$SNAP_ARCH" = "amd64" ]; then
88- ARCH="x86_64-linux-gnu"
89-elif [ "$SNAP_ARCH" = "armhf" ]; then
90- ARCH="arm-linux-gnueabihf"
91-else
92- ARCH="$SNAP_ARCH-linux-gnu"
93-fi
94-
95-export QTCHOOSER_NO_GLOBAL_DIR=1
96-export QT_SELECT=snappy-qt5
97-
98-# Qt Libs
99-export LD_LIBRARY_PATH=$SNAP/usr/lib/$ARCH/qt5/libs:$LD_LIBRARY_PATH
100-
101-# Qt Modules
102-export QT_PLUGIN_PATH=$SNAP/usr/lib/$ARCH/qt5/plugins
103-export QML2_IMPORT_PATH=$QML2_IMPORT_PATH:$SNAP/usr/lib/$ARCH/qt5/qml
104-export QML2_IMPORT_PATH=$QML2_IMPORT_PATH:$SNAP/lib/$ARCH
105-
106-# Necessary for the SDK to find the translations directory
107-export APP_DIR=$SNAP
108-
109-exec "$SNAP/bin/desktop-launch" "$SNAP/usr/lib/$ARCH/qt5/bin/qmlscene" "$@" $SNAP/usr/share/calendar-app/calendar.qml
110-

Subscribers

People subscribed via source and target branches

to status/vote changes: