Merge lp:~renatofilho/ubuntu-calculator-app/new-snappy into lp:ubuntu-calculator-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 316
Merged at revision: 312
Proposed branch: lp:~renatofilho/ubuntu-calculator-app/new-snappy
Merge into: lp:ubuntu-calculator-app
Diff against target: 297 lines (+220/-29)
3 files modified
app/ubuntu-calculator-app.qml (+5/-6)
setup/gui/ubuntu-calculator-app.desktop (+185/-0)
snapcraft.yaml (+30/-23)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-calculator-app/new-snappy
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Jenkins Bot continuous-integration Approve
Review via email: mp+310663@code.launchpad.net

Commit message

Using content share to reduce app size when snapped.
Make sure that desktop file has the same name as the snap binary name.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

LGTM! Tested on Ubuntu desktop.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/ubuntu-calculator-app.qml'
2--- app/ubuntu-calculator-app.qml 2016-08-18 11:48:03 +0000
3+++ app/ubuntu-calculator-app.qml 2016-11-11 15:50:49 +0000
4@@ -45,6 +45,11 @@
5 source: "engine/MathJs.qml"
6 asynchronous: true
7 active: keyboardLoader.active
8+ onLoaded: {
9+ mathJs.config({
10+ number: 'BigNumber'
11+ });
12+ }
13 }
14
15 // Long form of formula, which are saved in the storage/history
16@@ -135,9 +140,6 @@
17 }
18
19 function formulaPush(visual) {
20- mathJs.config({
21- number: 'bignumber'
22- });
23 // If the user press a number after the press of "=" we start a new
24 // formula, otherwise we continue with the old one
25 if ((!isNaN(visual) || (visual === ".")) && isLastCalculate) {
26@@ -204,9 +206,6 @@
27 }
28
29 function calculate() {
30- mathJs.config({
31- number: 'bignumber'
32- });
33 if ((longFormula === '') || (isLastCalculate === true)) {
34 errorAnimation.restart();
35 return;
36
37=== added directory 'setup'
38=== added directory 'setup/gui'
39=== added file 'setup/gui/icon.png'
40Binary files setup/gui/icon.png 1970-01-01 00:00:00 +0000 and setup/gui/icon.png 2016-11-11 15:50:49 +0000 differ
41=== added file 'setup/gui/ubuntu-calculator-app.desktop'
42--- setup/gui/ubuntu-calculator-app.desktop 1970-01-01 00:00:00 +0000
43+++ setup/gui/ubuntu-calculator-app.desktop 2016-11-11 15:50:49 +0000
44@@ -0,0 +1,185 @@
45+[Desktop Entry]
46+Name=Calculator
47+Name[aa]=Cisaabeyná
48+Name[am]=መደመሪያ
49+Name[ar]=الآلة الحاسبة
50+Name[ast]=Calculadora
51+Name[az]=Kalkulyator
52+Name[be]=Калькулятар
53+Name[bg]=Калкулатор
54+Name[br]=Jederez
55+Name[bs]=Kalkulator
56+Name[ca]=Calculadora
57+Name[ca@valencia]=Calculadora
58+Name[cs]=Kalkulačka
59+Name[cy]=Cyfrifiannell
60+Name[da]=Lommeregner
61+Name[de]=Taschenrechner
62+Name[el]=Αριθμομηχανή
63+Name[en_AU]=Calculator
64+Name[en_CA]=Calculator
65+Name[en_GB]=Calculator
66+Name[eo]=Kalkulilo
67+Name[es]=Calculadora
68+Name[eu]=Kalkulagailua
69+Name[fa]=ماشین‌حساب
70+Name[fi]=Laskin
71+Name[fo]=Roknitól
72+Name[fr]=Calculatrice
73+Name[fr_CA]=Calculatrice
74+Name[gd]=An t-àireamhair
75+Name[gl]=Calculadora
76+Name[gu]=કેલ્ક્યુલેટર
77+Name[he]=מחשבון
78+Name[hi]=कैलकुलेटर
79+Name[hr]=Kalkulator
80+Name[hu]=Számológép
81+Name[id]=Kalkulator
82+Name[is]=Reiknivél
83+Name[it]=Calcolatrice
84+Name[ja]=電卓
85+Name[km]=ម៉ាស៊ីន​គិត​លេខ
86+Name[ko]=계산기
87+Name[lv]=Kalkulators
88+Name[mr]=गणनयंत्र
89+Name[ms]=Kalkulator
90+Name[my]=ဂဏန်းတွက်စက်
91+Name[nb]=Kalkulator
92+Name[ne]=क्याल्कुलेटर
93+Name[nl]=Rekenmachine
94+Name[pa]=ਕੈਲਕੂਲੇਟਰ
95+Name[pl]=Kalkulator
96+Name[pt]=Calculadora
97+Name[pt_BR]=Calculadora
98+Name[ro]=Calculator
99+Name[ru]=Калькулятор
100+Name[sa]=सङ्कलकम्
101+Name[shn]=ၸၢၵ်ႈၼပ့်သွၼ်
102+Name[sk]=Kalkulačka
103+Name[sl]=Računalo
104+Name[sr]=Калкулатор
105+Name[sv]=Kalkylator
106+Name[ta]=கணிப்பான்
107+Name[te]=గణన పరికరం
108+Name[tr]=Hesap Makinesi
109+Name[ug]=ھېسابلىغۇچ
110+Name[uk]=Калькулятор
111+Name[uz]=Kalkulyator
112+Name[zh_CN]=计算器
113+Name[zh_HK]=計數機
114+Name[zh_TW]=計算機
115+Comment=A calculator for Ubuntu.
116+Comment[aa]=Ubuntu cisaabeyná
117+Comment[am]=ለ ኡቡንቱ ማስሊያ
118+Comment[ast]=Una calculadora pa Ubuntu
119+Comment[az]=Ubuntu üçün kalkulyator.
120+Comment[be]=Калькулятар Ubuntu.
121+Comment[br]=Ur jederez evit Ubuntu
122+Comment[bs]=Digitron za Ubuntu.
123+Comment[ca]=Una calculadora per a l'Ubuntu.
124+Comment[ca@valencia]=Una calculadora per a l'Ubuntu.
125+Comment[cs]=Kalkulátor pro Ubuntu.
126+Comment[cy]=Cyfrifiannell ar gyfer Ubuntu
127+Comment[da]=En lommeregner for Ubuntu.
128+Comment[de]=Ein Taschenrechner für Ubuntu
129+Comment[el]=Αριθμομηχανή για το Ubuntu.
130+Comment[en_AU]=A calculator for Ubuntu.
131+Comment[en_GB]=A calculator for Ubuntu.
132+Comment[eo]=Kalkulilo por Ubuntu.
133+Comment[es]=Una calculadora para Ubuntu.
134+Comment[eu]=Ubunturako kalkulagailu bat.
135+Comment[fa]=ماشین‌حسابی برای اویونتو
136+Comment[fi]=Laskin Ubuntulle
137+Comment[fo]=Eitt roknitól til Ubuntu.
138+Comment[fr]=Une calculatrice pour Ubuntu.
139+Comment[fr_CA]=Une calculatrice pour Ubuntu.
140+Comment[gd]=Àireamhair airson Ubuntu.
141+Comment[gl]=Calculadora para Ubuntu
142+Comment[he]=מחשבון לאובונטו.
143+Comment[hr]=Kalkulator za Ubuntu
144+Comment[hu]=Számológép Ubuntuhoz.
145+Comment[id]=Kalkulator untuk Ubuntu
146+Comment[it]=Una calcolatrice per Ubuntu.
147+Comment[lv]=Ubuntu kalkulators
148+Comment[ms]=Kalkulator untuk Ubuntu.
149+Comment[nb]=Kalkulatorprogram for Ubuntu.
150+Comment[nl]=Een rekenmachine voor Ubuntu.
151+Comment[pa]=ਉਬੰਤੂ ਲਈ ਇੱਕ ਕੈਲਕੁਲੇਟਰ
152+Comment[pl]=Kalkulator dla Ubuntu
153+Comment[pt]=Calculadora para Ubuntu.
154+Comment[pt_BR]=Uma calculadora para Ubuntu.
155+Comment[ro]=Un calculator pentru Ubuntu
156+Comment[ru]=Калькулятор для Ubuntu.
157+Comment[sk]=Kalkulačka pre Ubuntu
158+Comment[sl]=Računalo za Ubuntu
159+Comment[sr]=Калкулатор за Убунту.
160+Comment[sv]=En kalkylator för Ubuntu.
161+Comment[tr]=Ubuntu için bir hesap makinesi.
162+Comment[ug]=ئۇبۇنتۇدىكى ھېسابلىغۇچى
163+Comment[uk]=Калькулятор Ubuntu.
164+Comment[zh_CN]=Ubuntu适用的计算器。
165+Comment[zh_TW]=Ubuntu 計算機。
166+Keywords=math;addition;subtraction;multiplication;division;
167+Keywords[aa]=cisab;ossa;kalti;agra;kura;
168+Keywords[am]=ሂሳብ;መደመሪያ;መቀነሻ;ማባዣ;ማካፈያ;
169+Keywords[ar]=رياضة;ياضيات;حساب;حسابات;جمع;طرح;ضرب;قسمة;
170+Keywords[ast]=matemática;suma;resta;multiplicación;división;
171+Keywords[az]=riyaziyyat;әlavә etmә;çıxma;vurma;bölmә;toplama;
172+Keywords[be]=math;addition;subtraction;multiplication;division;математика;додавання;віднімання;множення;ділення;калькулятор;
173+Keywords[br]=matematikoù;sammadenn;lamadenn;lieskementadenn;rannadenn;
174+Keywords[bs]=matematičke operacije;sabiranje;oduzimanje;množenje;dijeljenje
175+Keywords[ca]=suma;resta;calculadora;multiplica;divideix
176+Keywords[ca@valencia]=suma;resta;calculadora;multiplica;divideix
177+Keywords[cs]=matematika;sčítání;dělení;odčítání;násobení
178+Keywords[cy]=math;adio;tynnu;lluosi;rhannu;
179+Keywords[da]=matematik;plus;minus;gange;dividere;beregning;lommeregner;
180+Keywords[de]=Mathe;Mathematik;Multiplikation;Subtraktion;Addition;Division;
181+Keywords[el]=math;addition;subtraction;multiplication;division;μαθηματικά;μαθηματικα;πρόσθεση;προσθεση;αφαίρεση;αφαίρεση;πολλαπλασιασμός;πολλαπλασιασμος;διαίρεση;διαιρεση;
182+Keywords[en_AU]=math;addition;subtraction;multiplication;division;
183+Keywords[en_GB]=maths;addition;subtraction;multiplication;division;
184+Keywords[es]=matemática;suma;resta;multiplicación;división;
185+Keywords[eu]=matematikak;gehitu;kendu;biderkatu;zatitu;
186+Keywords[fa]=math;addition;subtraction;multiplication;division;
187+Keywords[fi]=math;addition;subtraction;multiplication;division;matematiikka;lisäys;vähennys;kertaus;jakaminen;
188+Keywords[fo]=støddfrøði;samanlegging;frádráttur;falding;býting
189+Keywords[fr]=math;addition;soustraction;multiplication;division;
190+Keywords[fr_CA]=maths;maths;addition;soustraction;multiplication;division;
191+Keywords[gd]=math;addition;subtraction;multiplication;division;matamataig;roinneadh;toirt air falbh;cur ris;iomadadh
192+Keywords[gl]=matemáticas;suma;resta;multiplicación;división;
193+Keywords[he]=מתמטיקה;חשבון;חיבור;חיסור;כפל;חילוק;
194+Keywords[hr]=math;addition;subtraction;multiplication;division;
195+Keywords[hu]=számolás;összeadás;kivonás;szorzás;osztás;
196+Keywords[id]=math;addition;subtraction;multiplication;division;matematika;penjumlahan;pengurangan;perkalian;pembagian;
197+Keywords[is]=reikna;samlagning;frádráttur;margföldun;deiling
198+Keywords[it]=matematica;addizioni;sottrazioni;moltiplicazioni;divisioni;
199+Keywords[ja]=math;addition;subtraction;multiplication;division;計算;電卓;足し算;引き算;かけ算;わり算;
200+Keywords[km]=math;addition;subtraction;multiplication;division;
201+Keywords[ko]=수학;덧셈;뺄셈;곱셈;나눗셈;
202+Keywords[lv]=matematika;saskaitīt;atņemt;reizināt;dalīt;
203+Keywords[ms]=matematik;tambah;tolak;darab;bahagi;
204+Keywords[nb]=matte;addisjon;subtraksjon;multiplikasjon;divisjon;
205+Keywords[ne]=गणित; जोड्; घटाउ; गुणन; विभाजन;
206+Keywords[nl]=wiskunde;optellen;aftrekken;vermenigvuldigen;delen;
207+Keywords[pa]=ਹਿਸਾਬ;ਜੋੜ;ਘਟਾਉ;ਗੁਣਾ;ਭਾਗ;
208+Keywords[pl]=liczenie;dodawanie;odejmowanie;mnożenie;dzielenie;
209+Keywords[pt]=matemática;soma;subtracção;multiplicação;divisão;
210+Keywords[pt_BR]=matemática;adição;subtração;multiplicação;divisão
211+Keywords[ro]=matematică;adunare;scădere;înmulțire;împărțire
212+Keywords[ru]=математика;сложение;умножение;деление;
213+Keywords[sa]=गणितम्;योजनम्;वियोजनम्;गुणनम्;विभाजनम्;
214+Keywords[sk]=matematika;sčítanie;odčítanie;násobenie;delenie;
215+Keywords[sl]=matematika;seštevanje;odštevanje;množenje;deljenje;
216+Keywords[sr]=математика;сабирање;одузимање;множење;дељење;
217+Keywords[sv]=matematik;addition;subtraktion;multiplikation;division
218+Keywords[tr]=matematik;ekleme;çıkarma;çarpma;bölme;toplama
219+Keywords[ug]=ماتېماتىكا;قوشۇش;ئېلىش;كۆپەيتىش;بۆلۈش;
220+Keywords[uk]=math;addition;subtraction;multiplication;division;математика;додавання;віднімання;множення;ділення;калькулятор;
221+Keywords[zh_CN]=数学;加;减;乘;除;
222+Keywords[zh_TW]=math;addition;subtraction;multiplication;division;數學;加;減;乘;除;
223+Exec=ubuntu-calculator-app %u
224+Icon=/snap/ubuntu-calendar-app/current/ubuntu-calculator-app.png
225+Terminal=false
226+Type=Application
227+X-Ubuntu-Touch=true
228+X-Ubuntu-Default-Department-ID=accessories
229+X-Ubuntu-Splash-Color=#F5F5F5
230
231=== added directory 'snap'
232=== added directory 'snap/ubuntu-app-platform'
233=== modified file 'snapcraft.yaml'
234--- snapcraft.yaml 2016-07-12 14:53:12 +0000
235+++ snapcraft.yaml 2016-11-11 15:50:49 +0000
236@@ -1,31 +1,38 @@
237 name: ubuntu-calculator-app
238-version: 2.1+snap3
239+version: 2.3
240 summary: Ubuntu Calculator app
241 description: The calculator app for all Ubuntu devices.
242 confinement: strict
243-
244+grade: stable
245
246 apps:
247- ubuntu-calculator-app:
248- command: desktop-launch $SNAP/usr/lib/*/qt5/bin/qmlscene $SNAP/usr/share/ubuntu-calculator-app/ubuntu-calculator-app.qml
249- plugs: [unity7, opengl]
250+ ubuntu-calculator-app:
251+ command: desktop-launch qmlscene --desktop_file_hint=unity8 $SNAP/usr/share/ubuntu-calculator-app/ubuntu-calculator-app.qml
252+ plugs: [opengl, platform, unity7]
253+
254+plugs:
255+ platform:
256+ interface: content
257+ content: ubuntu-app-platform1
258+ target: ubuntu-app-platform
259
260 parts:
261- calculator:
262- plugin: cmake
263- configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
264- source: .
265- build-packages:
266- - cmake
267- - gettext
268- - intltool
269- - python3
270- - qtbase5-dev
271- - qtdeclarative5-dev
272- stage-packages:
273- - ubuntu-sdk-libs
274- - qtubuntu-desktop
275- snap:
276- - -usr/share/doc
277- - -usr/include
278- after: [desktop/qt5]
279+ ubuntu-calculator-app:
280+ plugin: cmake
281+ configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
282+ source: .
283+ build-packages:
284+ - cmake
285+ - gettext
286+ - intltool
287+ - python3
288+ - qtbase5-dev
289+ - qtdeclarative5-dev
290+ snap:
291+ - -usr/share/doc
292+ - -usr/include
293+ after: [desktop-ubuntu-app-platform]
294+
295+ environment:
296+ source: snap/
297+ plugin: dump

Subscribers

People subscribed via source and target branches