Merge lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap into lp:ubuntu-calculator-app
Proposed by
Renato Araujo Oliveira Filho
on 2016-11-21
| Status: | Merged |
|---|---|
| Approved by: | Alan Pope πΊπ§π± π¦ on 2016-11-22 |
| Approved revision: | 316 |
| Merged at revision: | 315 |
| Proposed branch: | lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap |
| Merge into: | lp:ubuntu-calculator-app |
| Diff against target: |
12 lines (+1/-1) 1 file modified
setup/gui/ubuntu-calculator-app.desktop (+1/-1) |
| To merge this branch: | bzr merge lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alan Pope πΊπ§π± π¦ | 2016-11-21 | Approve on 2016-11-22 | |
| Jenkins Bot | continuous-integration | Approve on 2016-11-22 | |
|
Review via email:
|
|||
Commit Message
Fix icon path for snap package.
To post a comment you must log in.
| Alan Pope πΊπ§π± π¦ (popey) wrote : | # |
The Icon path should really be:-
Icon=${
Rather than hard wiring the /snap path, as there is no guarantee that /snap is valid on all platforms.
review:
Needs Fixing
PASSED: Continuous integration, rev:316
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
review:
Approve
(continuous-integration)
lp:~renatofilho/ubuntu-calculator-app/fix-icon-snap
updated
on 2016-11-22
- 316. By Renato Araujo Oliveira Filho on 2016-11-22
-
Use $SNAP envar as icon prefix path instead of hardcoded path.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:315
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/