Merge lp:~renatofilho/sync-monitor/split-calendar-and-contacts into lp:sync-monitor

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 39
Merged at revision: 36
Proposed branch: lp:~renatofilho/sync-monitor/split-calendar-and-contacts
Merge into: lp:sync-monitor
Diff against target: 131 lines (+1/-47)
6 files modified
accounts/applications/CMakeLists.txt (+0/-2)
accounts/applications/calendar-sync.application.in (+0/-12)
accounts/applications/contacts-sync.application.in (+0/-12)
accounts/services/google-caldav.service.in (+0/-16)
debian/control (+1/-2)
debian/sync-monitor-uoa.install (+0/-3)
To merge this branch: bzr merge lp:~renatofilho/sync-monitor/split-calendar-and-contacts
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+230239@code.launchpad.net

Commit message

Do no install calendar online account application file.

This will be installed by the calendar app.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
33. By Renato Araujo Oliveira Filho

Does not install calendar sync application file.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
34. By Renato Araujo Oliveira Filho

Removed unnecessary code or service file.

35. By Renato Araujo Oliveira Filho

Trunk merged.

36. By Renato Araujo Oliveira Filho

Added missing file.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
37. By Renato Araujo Oliveira Filho

Avoid break packages during the instalation.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
38. By Renato Araujo Oliveira Filho

Add Breaks property for new packages.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
39. By Renato Araujo Oliveira Filho

Use only one package to install all necessary files for online accounts.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accounts/applications/CMakeLists.txt'
2--- accounts/applications/CMakeLists.txt 2014-03-12 20:01:22 +0000
3+++ accounts/applications/CMakeLists.txt 2014-09-29 18:15:55 +0000
4@@ -1,11 +1,9 @@
5 set(APPLICATION_FILES
6 contacts-sync.application
7- calendar-sync.application
8 )
9
10 set(APPLICATION_OUTPUT_FILES
11 ${CMAKE_CURRENT_BINARY_DIR}/contacts-sync.application
12- ${CMAKE_CURRENT_BINARY_DIR}/calendar-sync.application
13 )
14
15
16
17=== removed file 'accounts/applications/calendar-sync.application.in'
18--- accounts/applications/calendar-sync.application.in 2014-08-26 08:09:51 +0000
19+++ accounts/applications/calendar-sync.application.in 1970-01-01 00:00:00 +0000
20@@ -1,12 +0,0 @@
21-<?xml version="1.0" encoding="UTF-8"?>
22-<application id="calendar-sync">
23- <_description>Calendar</_description>
24- <desktop-entry>sync-monitor-calendar.desktop</desktop-entry>
25- <translations>calendar-sync</translations>
26-
27- <service-types>
28- <service-type id="calendar">
29- <_description>Synchronize your calendar</_description>
30- </service-type>
31- </service-types>
32-</application>
33
34=== added file 'accounts/applications/contacts-sync.application.in'
35--- accounts/applications/contacts-sync.application.in 1970-01-01 00:00:00 +0000
36+++ accounts/applications/contacts-sync.application.in 2014-09-29 18:15:55 +0000
37@@ -0,0 +1,12 @@
38+<?xml version="1.0" encoding="UTF-8"?>
39+<application id="contacts-sync">
40+ <_description>Contacts</_description>
41+ <desktop-entry>sync-monitor-contacts.desktop</desktop-entry>
42+ <translations>contacts-sync</translations>
43+
44+ <service-types>
45+ <service-type id="contacts">
46+ <_description>Synchronize your contacts</_description>
47+ </service-type>
48+ </service-types>
49+</application>
50
51=== removed file 'accounts/applications/contacts-sync.application.in'
52--- accounts/applications/contacts-sync.application.in 2014-08-26 08:09:51 +0000
53+++ accounts/applications/contacts-sync.application.in 1970-01-01 00:00:00 +0000
54@@ -1,12 +0,0 @@
55-<?xml version="1.0" encoding="UTF-8"?>
56-<application id="contacts-sync">
57- <_description>Contacts</_description>
58- <desktop-entry>sync-monitor-contacts.desktop</desktop-entry>
59- <translations>contacts-sync</translations>
60-
61- <service-types>
62- <service-type id="contacts">
63- <_description>Synchronize your contacts</_description>
64- </service-type>
65- </service-types>
66-</application>
67
68=== modified file 'accounts/services/google-caldav.service.in'
69--- accounts/services/google-caldav.service.in 2014-04-07 22:00:28 +0000
70+++ accounts/services/google-caldav.service.in 2014-09-29 18:15:55 +0000
71@@ -4,20 +4,4 @@
72 <name>Google Calendar</name>
73 <provider>google</provider>
74 <icon>calendar</icon>
75-
76- <!-- default settings (account settings have precedence over these) -->
77- <template>
78- <group name="auth">
79- <setting name="method">oauth2</setting>
80- <setting name="mechanism">web_server</setting>
81- <group name="oauth2">
82- <group name="web_server">
83- <setting type="as" name="Scope">['email','https://www.googleapis.com/auth/calendar']</setting>
84- <!-- workaround for (g)signond token cache issue: use different client IDs for each service and the provider -->
85- <setting name="ClientId">759250720802-4sii0me9963n9fdqdmi7cepn6ub8luoh.apps.googleusercontent.com</setting>
86- <setting name="ClientSecret">juFngKUcuhB7IRQqHtSLavqJ</setting>
87- </group>
88- </group>
89- </group>
90- </template>
91 </service>
92
93=== modified file 'debian/control'
94--- debian/control 2014-09-05 11:49:50 +0000
95+++ debian/control 2014-09-29 18:15:55 +0000
96@@ -46,14 +46,13 @@
97 Depends: ${misc:Depends},
98 sync-monitor (>= ${binary:Version}),
99 Description: Ubuntu online account sync monitor plugin - service files
100- sync-monitor manages data synchronization of contacts and calendars
101+ sync-monitor manages data synchronization of calendars and contacts.
102 .
103 With this package you can keep track of Ubuntu online accounts and sync
104 with the cloud.
105 .
106 This package contains the ubuntu online accounts service files.
107
108-
109 Package: qtdeclarative5-ubuntu-syncmonitor0.1
110 Architecture: any
111 Multi-Arch: same
112
113=== added file 'debian/sync-monitor-uoa.install'
114--- debian/sync-monitor-uoa.install 1970-01-01 00:00:00 +0000
115+++ debian/sync-monitor-uoa.install 2014-09-29 18:15:55 +0000
116@@ -0,0 +1,7 @@
117+usr/share/accounts/services/google-caldav.service
118+usr/share/accounts/services/yahoo-caldav.service
119+usr/share/accounts/services/google-carddav.service
120+usr/share/accounts/services/yahoo-carddav.service
121+usr/share/applications/sync-monitor-contacts.desktop
122+usr/share/applications/sync-monitor-calendar.desktop
123+usr/share/accounts/applications/contacts-sync.application
124
125=== removed file 'debian/sync-monitor-uoa.install'
126--- debian/sync-monitor-uoa.install 2014-02-14 22:58:16 +0000
127+++ debian/sync-monitor-uoa.install 1970-01-01 00:00:00 +0000
128@@ -1,3 +0,0 @@
129-usr/share/accounts
130-usr/share/applications/sync-monitor-contacts.desktop
131-usr/share/applications/sync-monitor-calendar.desktop

Subscribers

People subscribed via source and target branches