Merge lp:~renatofilho/quick-memo/fix-item-focus into lp:quick-memo/trunk
Proposed by
Renato Araujo Oliveira Filho
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Stefano Verzegnassi | ||||
Approved revision: | 57 | ||||
Merged at revision: | 57 | ||||
Proposed branch: | lp:~renatofilho/quick-memo/fix-item-focus | ||||
Merge into: | lp:quick-memo/trunk | ||||
Diff against target: |
189 lines (+87/-30) 2 files modified
app/components/ListManager.qml (+77/-18) app/components/NoteTextField.qml (+10/-12) |
||||
To merge this branch: | bzr merge lp:~renatofilho/quick-memo/fix-item-focus | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stefano Verzegnassi | Approve | ||
Bill Filler (community) | Approve | ||
Review via email: mp+245761@code.launchpad.net |
Commit message
Fixed note items navigation and focus.
Description of the change
OBS: The keyboard "Enter" label still broken due a bug on ubuntu-keyboard, you will need this MR to get this fully working: https:/
To post a comment you must log in.
Hi Renato,
Thanks for reporting this issue and submitting a patch.
During these days I'm studying for some exams, so I don't have much time to spend with source code.
I'm working on the "reboot" branch for Quick Memo, using a new database (in order to solve some issue with U1DB) and refactoring some parts of code that don't look so good ("Details" page is one of those "parts").
I just took a look at the diff and the code looks good to me. I just need some time to make a deeper review of the code and integrate it in the "reboot" branch (which, I hope, should be "almost" ready to be receive MPs during the next weekend).
Thank you again! :)
Stefano