Merge lp:~renatofilho/messaging-app/fix-1489330 into lp:messaging-app

[Renato Araujo Oliveira Filho]

Only show favorite sections if the list contains favorite contacts.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:459
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/682/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4921/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/195/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4918/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/682/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/messaging-app/fix-1489330]

460. By Renato Araujo Oliveira Filho on 2015-11-05

Trunk merged.

461. By Renato Araujo Oliveira Filho on 2015-11-05

Trunk merged.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:460
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/693/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5036
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/206
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/4045
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5033
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5033/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24960

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/693/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/messaging-app/fix-1489330]

462. By Renato Araujo Oliveira Filho on 2015-11-06

Trunk merged.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:461
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/696/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5057
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/209
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/4055
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5060
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5060/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24981

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/696/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:462
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/698/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5072
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/211
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/4062
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5077
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5077/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24992

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/698/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/messaging-app/fix-1489330]

463. By Renato Araujo Oliveira Filho on 2015-12-10

Update NewRecipientPage to use the new ContactMap component.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:463
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/842/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5701
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/351
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4427
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5714
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5714/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25941

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/842/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/messaging-app/fix-1489330]

464. By Renato Araujo Oliveira Filho on 2015-12-10

Move back to 'all' contacts if the 'favorite' list is empty.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:464
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/844/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5713/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/353
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5726/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/844/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/messaging-app/fix-1489330]

465. By Renato Araujo Oliveira Filho on 2015-12-15

Show favorite section if the most called model is not empty.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:465
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/864/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5794
    SUCCESS: http://jenkins.qa.ubuntu.com/job/messaging-app-vivid-i386-ci/373
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4482
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5807
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5807/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26076

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/864/rebuild

review: Needs Fixing (continuous-integration)

[Gustavo Pichorim Boiko (boiko)]

Looks good!

review: Approve

[lp:~renatofilho/messaging-app/fix-1489330]

466. By Renato Araujo Oliveira Filho on 2016-01-14

Trunk merged.

467. By Renato Araujo Oliveira Filho on 2016-05-16

Trunk merged.

[system-apps-ci-bot (system-apps-ci-bot)]

FAILED: Continuous integration, rev:467
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/28/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/755/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/755
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/702
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/702
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/702
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/694/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/694
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/694/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/694
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/694/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/694/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/694
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/694/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/694
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/694/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/694/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/694
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/694/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/694
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/694/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-messaging-app-ci/28/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

467. By Renato Araujo Oliveira Filho on 2016-05-16

Trunk merged.

466. By Renato Araujo Oliveira Filho on 2016-01-14

Trunk merged.

465. By Renato Araujo Oliveira Filho on 2015-12-15

Show favorite section if the most called model is not empty.

464. By Renato Araujo Oliveira Filho on 2015-12-10

Move back to 'all' contacts if the 'favorite' list is empty.

463. By Renato Araujo Oliveira Filho on 2015-12-10

Update NewRecipientPage to use the new ContactMap component.

462. By Renato Araujo Oliveira Filho on 2015-11-06

Trunk merged.

461. By Renato Araujo Oliveira Filho on 2015-11-05

Trunk merged.

460. By Renato Araujo Oliveira Filho on 2015-11-05

Trunk merged.

459. By Renato Araujo Oliveira Filho on 2015-10-29

Only show favorite sections if the list contains favorite contacts.

=== modified file 'src/qml/NewRecipientPage.qml'
--- src/qml/NewRecipientPage.qml	2016-03-16 18:05:07 +0000
+++ src/qml/NewRecipientPage.qml	2016-05-16 15:53:55 +0000
@@ -74,8 +74,23 @@
 
     Sections {
         id: headerSections
-        model: [i18n.tr("All"), i18n.tr("Favorites")]
+        model: contactMap.hasFavorites || (contactList.mostCalledCount > 0) ?
+                                    [ i18n.tr("All"), i18n.tr("Favorites") ] : []
+        onModelChanged: selectedIndex = 0
+        onSelectedIndexChanged: {
+            switch (selectedIndex) {
+            case 0:
+                contactList.showAllContacts()
+                break;
+            case 1:
+                contactList.showFavoritesContacts()
+                break;
+            default:
+                break;
+            }
+        }
     }
+
     TextField {
         id: searchField
 
@@ -157,6 +172,10 @@
         }
     ]
 
+    ContactMap {
+        id: contactMap
+    }
+
     ContactListView {
         id: contactList
         objectName: "newRecipientList"
@@ -213,22 +232,6 @@
     }
 
     Connections {
-        target: headerSections
-        onSelectedIndexChanged: {
-            switch (headerSections.selectedIndex) {
-            case 0:
-                contactList.showAllContacts()
-                break;
-            case 1:
-                contactList.showFavoritesContacts()
-                break;
-            default:
-                break;
-            }
-        }
-    }
-
-    Connections {
         target: contactList.listModel
         onContactsChanged: {
             if (newRecipientPage.contactIndex) {