Merge lp:~renatofilho/messaging-app/fix-1368337 into lp:messaging-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 241
Merged at revision: 255
Proposed branch: lp:~renatofilho/messaging-app/fix-1368337
Merge into: lp:messaging-app
Diff against target: 56 lines (+14/-15)
2 files modified
src/qml/MessageDelegateFactory.qml (+0/-1)
src/qml/MessagesListView.qml (+14/-14)
To merge this branch: bzr merge lp:~renatofilho/messaging-app/fix-1368337
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+234885@code.launchpad.net

Commit message

Changed swipe list item to not activate on mouse release.
Changed actions order on Message delegate.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
yes

Did CI run pass? If not, please explain why.
yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/MessageDelegateFactory.qml'
2--- src/qml/MessageDelegateFactory.qml 2014-08-28 21:54:12 +0000
3+++ src/qml/MessageDelegateFactory.qml 2014-09-16 20:22:31 +0000
4@@ -36,7 +36,6 @@
5 signal copyMessage()
6 signal showMessageDetails()
7
8- triggerActionOnMouseRelease: true
9 width: messageList.width
10 leftSideAction: Action {
11 iconName: "delete"
12
13=== modified file 'src/qml/MessagesListView.qml'
14--- src/qml/MessagesListView.qml 2014-09-09 23:11:20 +0000
15+++ src/qml/MessagesListView.qml 2014-09-16 20:22:31 +0000
16@@ -60,20 +60,6 @@
17 currentIndex: 0
18 _availableActions: [
19 Action {
20- id: reloadAction
21-
22- iconName: "reload"
23- text: i18n.tr("Retry")
24- onTriggered: value.resendMessage()
25- },
26- Action {
27- id: copyAction
28-
29- iconName: "edit-copy"
30- text: i18n.tr("Copy")
31- onTriggered: value.copyMessage()
32- },
33- Action {
34 id: infoAction
35
36 iconName: "info"
37@@ -89,6 +75,20 @@
38 "participants": messages.participants}
39 messageInfoDialog.showMessageInfo(messageInfo)
40 }
41+ },
42+ Action {
43+ id: reloadAction
44+
45+ iconName: "reload"
46+ text: i18n.tr("Retry")
47+ onTriggered: value.resendMessage()
48+ },
49+ Action {
50+ id: copyAction
51+
52+ iconName: "edit-copy"
53+ text: i18n.tr("Copy")
54+ onTriggered: value.copyMessage()
55 }
56 ]
57

Subscribers

People subscribed via source and target branches