Merge lp:~renatofilho/mediaplayer-app/translators-comments into lp:mediaplayer-app

[Renato Araujo Oliveira Filho]

Added comments for TRANSLATORS.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:87
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/56/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-amd64-ci/27
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-armhf-ci/56
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-armhf-ci/56/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-i386-ci/55
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1615

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mediaplayer-app-ci/56/rebuild

review: Needs Fixing (continuous-integration)

[Olivier Tilloy (osomon)]

Looks good. Just a tiny wording nit pick:

80 + // TRANSLATORS: this refers to an unknown amount of time.

I would say "this refers to an unknown duration".

[David Planella (dpm)]

Thanks Renato. Just two comments:

85 if (min < 10) min = i18n.tr("0%1").arg(min)

This (and the other two ones for sec and hour) needs a comment too. E.g.

// TRANSLATORS: %1 refers to a number of minutes smaller than 10, preceded by a leading 0

88 + // TRANSLATORS: this refers to a duration/remaining time of the video this can not be translated using date time location

There needs to be an indication of what each arg means, and translators are probably not interested in whether it could be internationalized with date. I'd suggest the following comment:

// TRANSLATORS: this refers to a duration/remaining time of the video, of which you can change the order. %1 refers to hours, %2 refers to minutes and %3 refers to seconds

review: Needs Fixing

[lp:~renatofilho/mediaplayer-app/translators-comments]

88. By Renato Araujo Oliveira Filho on 2013-05-23

Rewrite TRANSLATORS comments.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:88
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/58/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-amd64-ci/29
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-armhf-ci/58
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-armhf-ci/58/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-i386-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1632

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mediaplayer-app-ci/58/rebuild

review: Approve (continuous-integration)

[lp:~renatofilho/mediaplayer-app/translators-comments]

89. By Renato Araujo Oliveira Filho on 2013-05-23

Updated pot file.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:89
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/59/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-amd64-ci/30
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-raring-i386-ci/58
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1641

Click here to trigger a rebuild:
http://s-jenkins:8080/job/mediaplayer-app-ci/59/rebuild

review: Approve (continuous-integration)

[lp:~renatofilho/mediaplayer-app/translators-comments]

90. By Renato Araujo Oliveira Filho on 2014-09-29

Trunk Merged.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/225/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5297
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3837
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/33
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/33/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-i386-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5016
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6549
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6549/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13893
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3220
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4148
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4148/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/225/rebuild

review: Approve (continuous-integration)

[David Planella (dpm)]

Thanks. I've added a couple of inline comments.

Also, could the po/pt_BR.po file be removed from the diff? Translations should be done in Launchpad, and they will overwrite the .po file anyway.

review: Needs Fixing

[Renato Araujo Oliveira Filho (renatofilho)]

> Thanks. I've added a couple of inline comments.
>
> Also, could the po/pt_BR.po file be removed from the diff? Translations should
> be done in Launchpad, and they will overwrite the .po file anyway.

Ok. I will remove the pt_BR file. But the launchpad is very unstable and I am receiving timeout every time that I sent a suggestion. I was talking with
a translator guys from the translator team and he told me to do the translator in the po file and push it.

[lp:~renatofilho/mediaplayer-app/translators-comments]

91. By Renato Araujo Oliveira Filho on 2014-09-30

Removed unnecessary strings for translation.

92. By Renato Araujo Oliveira Filho on 2014-09-30

Reverted changes on pt_BR.po

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:92
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/226/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5321
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3846
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/34
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/34/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-i386-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5033
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6573
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6573/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13922
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3227
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4159
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4159/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/226/rebuild

review: Approve (continuous-integration)

[lp:~renatofilho/mediaplayer-app/translators-comments]

93. By Renato Araujo Oliveira Filho on 2014-10-02

Merged: lp:~aacid/mediaplayer-app/addi18ntr

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:93
http://jenkins.qa.ubuntu.com/job/mediaplayer-app-ci/231/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5444
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3898
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-amd64-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/39
        deb: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-armhf-ci/39/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mediaplayer-app-utopic-i386-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5138
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6696
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6696/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14075
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3272
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4215
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4215/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mediaplayer-app-ci/231/rebuild

review: Approve (continuous-integration)

=== modified file 'src/qml/player.qml'
--- src/qml/player.qml	2014-01-07 19:36:45 +0000
+++ src/qml/player.qml	2014-10-02 18:23:00 +0000
@@ -68,7 +68,7 @@
             text: i18n.tr("No video selected to play. Connect your phone to your computer to transfer videos to the phone. Then select video from Videos lens.")
 
             Button {
-                text: "Ok"
+                text: i18n.tr("Ok")
                 gradient: UbuntuColors.greyGradient
                 onClicked: Qt.quit()
             }

=== modified file 'src/qml/player/TimeLine.qml'
--- src/qml/player/TimeLine.qml	2013-12-20 20:04:41 +0000
+++ src/qml/player/TimeLine.qml	2014-10-02 18:23:00 +0000
@@ -65,6 +65,7 @@
                 if (_slider.maximumValue > 0) {
                     _timeLine.remainingTime = formatProgress(_slider.maximumValue - value)
                 } else {
+                    // TRANSLATORS: this refers to an unknown duration.
                     _timeLine.remainingTime = i18n.tr("unknown")
                 }
             } else {
@@ -101,7 +102,7 @@
             },
             State {
                 name: "DEGRESSIVE"
-                PropertyChanges { target: _TimeLabel; text: i18n.tr("- %1").arg(_timeLine.remainingTime) }
+                PropertyChanges { target: _TimeLabel; text: "- %1".arg(_timeLine.remainingTime) }
             }
         ]
 
@@ -128,10 +129,12 @@
         min = time % 60
         hour = Math.floor(time / 60)
 
-        if (secs < 10) secs = i18n.tr("0%1").arg(secs)
-        if (min < 10) min = i18n.tr("0%1").arg(min)
-        if (hour < 10) hour = i18n.tr("0%1").arg(hour)
+        if (secs < 10) secs = "0%1".arg(secs)
+        if (min < 10) min = "0%1".arg(min)
+        if (hour < 10) hour = "0%1".arg(hour)
 
+        // TRANSLATORS: this refers to a duration/remaining time of the video, of which you can change the order.
+        // %1 refers to hours, %2 refers to minutes and %3 refers to seconds.
         return  i18n.tr("%1:%2:%3").arg(hour).arg(min).arg(secs)
     }
 }