Merge lp:~renatofilho/mediaplayer-app/new-sdk-name into lp:mediaplayer-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Michael Zanetti
Approved revision: 64
Merged at revision: 62
Proposed branch: lp:~renatofilho/mediaplayer-app/new-sdk-name
Merge into: lp:mediaplayer-app
Diff against target: 53 lines (+8/-10)
2 files modified
debian/control (+2/-1)
tests/autopilot/mediaplayer_app/tests/test_player_with_video.py (+6/-9)
To merge this branch: bzr merge lp:~renatofilho/mediaplayer-app/new-sdk-name
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+154491@code.launchpad.net

Commit message

Update runtime dependencies to account for the renaming of the UI toolkit package.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
63. By Renato Araujo Oliveira Filho

[autopilot] Make sure that the scene selector stops moving before click on scene

64. By Renato Araujo Oliveira Filho

Added 'qtmultimedia5-dev' into binary dependecy list because it contains the necessary plugin to play multimedia files.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-03-18 18:14:37 +0000
3+++ debian/control 2013-03-21 20:19:21 +0000
4@@ -26,7 +26,8 @@
5 qtdeclarative5-qtmultimedia-plugin | libqt5declarative5-qtmultimedia-plugin,
6 qtdeclarative5-window-plugin,
7 qtdeclarative5-xmllistmodel-plugin,
8- qt-components-ubuntu,
9+ qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
10+ qtmultimedia5-dev,
11 libhud-qt-qml,
12 gstreamer0.10-ffmpeg,
13 gstreamer0.10-plugins-base,
14
15=== modified file 'tests/autopilot/mediaplayer_app/tests/test_player_with_video.py'
16--- tests/autopilot/mediaplayer_app/tests/test_player_with_video.py 2013-03-06 20:47:01 +0000
17+++ tests/autopilot/mediaplayer_app/tests/test_player_with_video.py 2013-03-21 20:19:21 +0000
18@@ -94,29 +94,26 @@
19 slider = self.main_window.get_object("Slider", "TimeLine.Slider")
20 time_line = self.main_window.get_object("TimeLine", "TimeLine")
21 selector = self.main_window.get_object("SceneSelector", "Controls.SceneSelector")
22- self.assertThat(selector.count, Eventually(GreaterThan(3)))
23-
24- scene_2 = self.main_window.get_object("SceneFrame", "SceneSelector.Scene2")
25- self.assertThat(scene_2.ready, Eventually(Equals(True)))
26-
27+ self.assertThat(selector.count, Eventually(GreaterThan(3)))
28
29 """ Show scene selector """
30 self.mouse.move_to_object(slider)
31 self.mouse.click()
32
33 """ Make sure that the scenes are in correct place """
34+ scene_0 = self.main_window.get_object("SceneFrame", "SceneSelector.Scene0")
35 selectorRect = selector.globalRect
36 self.pointing_device.drag(selectorRect[0], selectorRect[1] + selectorRect[3] / 2,
37 selectorRect[0] + selectorRect[2], selectorRect[1] + selectorRect[3] / 2)
38- scene_0 = self.main_window.get_object("SceneFrame", "SceneSelector.Scene0")
39- self.assertThat(scene_0.x, Eventually(GreaterThan(-1)))
40-
41+ self.assertThat(selector.moving, Eventually(Equals(False)))
42+ self.assertThat(scene_0.x, Eventually(Equals(0)))
43
44 """ Click in the second scene """
45+ scene_2 = self.main_window.get_object("SceneFrame", "SceneSelector.Scene2")
46+ self.assertThat(scene_2.ready, Eventually(Equals(True)))
47 self.mouse.move_to_object(scene_2)
48 self.mouse.click()
49 self.assertThat(selector.currentIndex, Eventually(Equals(2)))
50-
51 self.assertProperty(time_line, value=1.113)
52
53 def test_time_display_behavior(self):

Subscribers

People subscribed via source and target branches