Merge lp:~renatofilho/mediaplayer-app/fix-1230404 into lp:mediaplayer-app

Proposed by Bill Filler
Status: Merged
Approved by: Francis Ginther
Approved revision: 146
Merged at revision: 151
Proposed branch: lp:~renatofilho/mediaplayer-app/fix-1230404
Merge into: lp:mediaplayer-app
Diff against target: 34 lines (+11/-1)
1 file modified
src/qml/player.qml (+11/-1)
To merge this branch: bzr merge lp:~renatofilho/mediaplayer-app/fix-1230404
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Approve
Review via email: mp+189513@code.launchpad.net

Commit message

uri handler

Description of the change

uri handler

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Manually merged via jenkins. The failures are due to a known issue and unrelated to the MP.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/player.qml'
2--- src/qml/player.qml 2013-09-03 15:24:02 +0000
3+++ src/qml/player.qml 2013-10-06 21:40:27 +0000
4@@ -23,6 +23,7 @@
5 import QtQuick.Window 2.0
6 import QtMultimedia 5.0
7 import Ubuntu.Unity.Action 1.0 as UnityActions
8+import Ubuntu.Components 0.1
9
10 Rectangle {
11 id: mediaPlayer
12@@ -58,7 +59,7 @@
13 anchors.fill: parent
14 clip: true
15 onLoaded: {
16- item.focus = true
17+ item.focus = true
18 item.rotating = Qt.binding(function () { return rotatingTransition.running } )
19 item.playUri(playUri)
20 }
21@@ -191,4 +192,13 @@
22 rotateCounterClockwise()
23 }
24 }
25+
26+ Connections {
27+ target: UriHandler
28+ onOpened: {
29+ for (var i = 0; i < uris.length; ++i) {
30+ playerLoader.item.playUri(uris[i])
31+ }
32+ }
33+ }
34 }

Subscribers

People subscribed via source and target branches