Merge lp:~renatofilho/mediaplayer-app/fix-1182961 into lp:mediaplayer-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Omer Akram
Approved revision: 85
Merged at revision: 85
Proposed branch: lp:~renatofilho/mediaplayer-app/fix-1182961
Merge into: lp:mediaplayer-app
Diff against target: 26 lines (+12/-3)
1 file modified
src/mediaplayer.cpp (+12/-3)
To merge this branch: bzr merge lp:~renatofilho/mediaplayer-app/fix-1182961
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+165211@code.launchpad.net

Commit message

Check if the uri passed as argument is a valid file before play it.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Omer Akram (om26er) wrote :

WFM +1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/mediaplayer.cpp'
2--- src/mediaplayer.cpp 2013-02-26 19:15:41 +0000
3+++ src/mediaplayer.cpp 2013-05-22 17:54:27 +0000
4@@ -83,10 +83,19 @@
5 m_view->setTitle("Media Player");
6 if (args.count() >= 2) {
7 QUrl uri(args[1]);
8- if (uri.isRelative()) {
9- uri = QUrl::fromLocalFile(QDir::current().absoluteFilePath(args[1]));
10+ if (uri.isValid()) {
11+ QFileInfo info(uri.toString());
12+ if (info.exists() && info.isFile()) {
13+ if (uri.isRelative()) {
14+ uri = QUrl::fromLocalFile(QDir::current().absoluteFilePath(args[1]));
15+ }
16+ m_view->rootContext()->setContextProperty("playUri", uri);
17+ } else {
18+ qWarning() << "File not found:" << uri << info.exists() << info.isFile();
19+ }
20+ } else {
21+ qWarning() << "Invalid uri:" << uri;
22 }
23- m_view->rootContext()->setContextProperty("playUri", uri);
24 }
25
26 m_view->rootContext()->setContextProperty("screenWidth", m_view->size().width());

Subscribers

People subscribed via source and target branches