Merge lp:~renatofilho/libdbusmenu-qt/qt5 into lp:libdbusmenu-qt

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 237
Merged at revision: 238
Proposed branch: lp:~renatofilho/libdbusmenu-qt/qt5
Merge into: lp:libdbusmenu-qt
Diff against target: 54 lines (+16/-1)
2 files modified
CMakeLists.txt (+14/-1)
src/CMakeLists.txt (+2/-0)
To merge this branch: bzr merge lp:~renatofilho/libdbusmenu-qt/qt5
Reviewer Review Type Date Requested Status
DBus Menu Team Pending
Review via email: mp+141665@code.launchpad.net

Description of the change

From: David Faure <email address hidden>

It makes it compile against Qt5 when Qt5 is found, but keeps full
compatibility with Qt4 otherwise.

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2012-03-29 15:47:30 +0000
3+++ CMakeLists.txt 2013-01-02 20:01:21 +0000
4@@ -44,14 +44,25 @@
5 )
6 add_dependencies(distcheck dist)
7
8+find_package(Qt5Widgets QUIET)
9+if (Qt5Widgets_FOUND)
10+ find_package(Qt5DBus REQUIRED)
11+ include_directories(${Qt5Widgets_INCLUDE_DIRS} ${Qt5DBus_INCLUDE_DIRS})
12+ find_package(extra-cmake-modules 0.0.2 REQUIRED)
13+ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${EXTRA_CMAKE_MODULES_MODULE_PATH})
14+ find_package(Qt5Transitional REQUIRED Core)
15+ set(CMAKE_AUTOMOC ON)
16+ set(CMAKE_AUTOMOC_RELAXED_MODE ON)
17+else()
18 find_package(Qt4 REQUIRED)
19-
20 include_directories(
21 ${QT_INCLUDE_DIR}
22 ${QT_QTCORE_INCLUDE_DIR}
23 ${QT_QTDBUS_INCLUDE_DIR}
24 ${QT_QTGUI_INCLUDE_DIR}
25 )
26+endif()
27+
28
29 configure_file(dbusmenu-qt.pc.in ${CMAKE_BINARY_DIR}/dbusmenu-qt.pc @ONLY)
30
31@@ -60,7 +71,9 @@
32 )
33
34 add_subdirectory(src)
35+if (NOT Qt5Widgets_FOUND) # TODO port tests to Qt5
36 add_subdirectory(tests)
37+endif()
38 add_subdirectory(tools)
39
40 if(WITH_DOC)
41
42=== modified file 'src/CMakeLists.txt'
43--- src/CMakeLists.txt 2012-04-23 14:48:31 +0000
44+++ src/CMakeLists.txt 2013-01-02 20:01:21 +0000
45@@ -49,7 +49,9 @@
46 ${CMAKE_BINARY_DIR}/src
47 )
48
49+if (NOT Qt5Widgets_FOUND)
50 qt4_automoc(${dbusmenu_qt_SRCS})
51+endif()
52
53 qt4_add_dbus_adaptor(dbusmenu_qt_SRCS
54 ${CMAKE_CURRENT_SOURCE_DIR}/com.canonical.dbusmenu.xml

Subscribers

People subscribed via source and target branches