Merge lp:~renatofilho/indicator-messages/phablet-fix-1181371 into lp:indicator-messages/phablet

Proposed by Ted Gould
Status: Rejected
Rejected by: Ted Gould
Proposed branch: lp:~renatofilho/indicator-messages/phablet-fix-1181371
Merge into: lp:indicator-messages/phablet
Diff against target: 55 lines (+12/-3)
4 files modified
debian/changelog (+7/-0)
src/app-section.c (+1/-1)
src/ido-detail-label.c (+3/-2)
src/im-application-list.c (+1/-0)
To merge this branch: bzr merge lp:~renatofilho/indicator-messages/phablet-fix-1181371
Reviewer Review Type Date Requested Status
Ted Gould (community) Disapprove
PS Jenkins bot (community) continuous-integration Approve
Sergio Schvezov Needs Fixing
Lars Karlitski (community) Approve
Review via email: mp+167163@code.launchpad.net

Commit message

Update indicator icon after remove all messages.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Not sure yet why this fixes the bug (as I can't reproduce it), but I'm fine with this going in temporarily.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
365. By Renato Araujo Oliveira Filho

Replaced deprecated functions.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Since this is changelog dput based can you update the changelog and mark the series for saucy?

review: Needs Fixing
366. By Renato Araujo Oliveira Filho

releasing version 13.11.0phablet1

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

The phablet branch is deprecated. I don't think this merge is still valid. If it is, please repropose into trunk.

review: Disapprove

Unmerged revisions

366. By Renato Araujo Oliveira Filho

releasing version 13.11.0phablet1

365. By Renato Araujo Oliveira Filho

Replaced deprecated functions.

364. By Renato Araujo Oliveira Filho

Try to fix blue icon.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-26 16:54:41 +0000
3+++ debian/changelog 2013-06-05 18:09:25 +0000
4@@ -1,3 +1,10 @@
5+indicator-messages (13.11.0phablet1) saucy; urgency=low
6+
7+ * Fixed indicator blue icon.
8+ * Removed use of deprecated functions.
9+
10+ -- Renato Araujo Oliveira Filho <renato@canonical.com> Wed, 05 Jun 2013 15:06:03 -0300
11+
12 indicator-messages (13.10.0phablet1) raring; urgency=low
13
14 * Version bump to not pull from archives
15
16=== modified file 'src/app-section.c'
17--- src/app-section.c 2012-11-14 16:57:54 +0000
18+++ src/app-section.c 2013-06-05 18:09:25 +0000
19@@ -301,7 +301,7 @@
20
21 g_return_if_fail(priv->ids != NULL);
22
23- if (!indicator_desktop_shortcuts_nick_exec(priv->ids, nick)) {
24+ if (!indicator_desktop_shortcuts_nick_exec_with_context(priv->ids, nick, NULL)) {
25 g_warning("Unable to execute nick '%s' for desktop file '%s'",
26 nick, g_desktop_app_info_get_filename (priv->appinfo));
27 }
28
29=== modified file 'src/ido-detail-label.c'
30--- src/ido-detail-label.c 2012-09-04 17:20:20 +0000
31+++ src/ido-detail-label.c 2013-06-05 18:09:25 +0000
32@@ -140,8 +140,9 @@
33 {
34 const PangoFontDescription *font;
35
36- font = gtk_style_context_get_font (gtk_widget_get_style_context (widget),
37- gtk_widget_get_state_flags (widget));
38+ gtk_style_context_get (gtk_widget_get_style_context (widget),
39+ gtk_widget_get_state_flags (widget),
40+ "font", &font, NULL);
41
42 return pango_context_get_metrics (context,
43 font,
44
45=== modified file 'src/im-application-list.c'
46--- src/im-application-list.c 2012-12-20 16:46:15 +0000
47+++ src/im-application-list.c 2013-06-05 18:09:25 +0000
48@@ -277,6 +277,7 @@
49 g_strfreev (source_actions);
50 g_strfreev (message_actions);
51 }
52+ im_application_list_update_draws_attention (app->list);
53 }
54
55 static void

Subscribers

People subscribed via source and target branches