Merge lp:~renatofilho/dialer-app/swipe-item-demo into lp:dialer-app
| Status: | Merged |
|---|---|
| Approved by: | Gustavo Pichorim Boiko on 2015-05-07 |
| Approved revision: | 385 |
| Merged at revision: | 402 |
| Proposed branch: | lp:~renatofilho/dialer-app/swipe-item-demo |
| Merge into: | lp:dialer-app |
| Diff against target: |
552 lines (+485/-1) 5 files modified
src/qml/HistoryPage/HistoryPage.qml (+16/-0) src/qml/HistoryPage/SwipeItemDemo.qml (+397/-0) src/qml/assets/swipe_arrow.svg (+17/-0) tests/autopilot/dialer_app/tests/__init__.py (+23/-1) tests/autopilot/dialer_app/tests/test_logs.py (+32/-0) |
| To merge this branch: | bzr merge lp:~renatofilho/dialer-app/swipe-item-demo |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Pichorim Boiko (community) | 2015-02-26 | Approve on 2015-05-07 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-05-07 | |
|
Review via email:
|
|||
Commit Message
Create a swipe item demo. To demonstrate how to swipe items to revel actions.
Description of the Change
You will need this to get this working: https:/
- 374. By Renato Araujo Oliveira Filho on 2015-02-26
-
Show a fake missed call on Swipe demo.
Only shows the demo if the list is populated.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:374
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 375. By Renato Araujo Oliveira Filho on 2015-04-27
-
Trunk merged.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:375
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:375
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 376. By Renato Araujo Oliveira Filho on 2015-04-28
-
Updated visuals.
- 377. By Renato Araujo Oliveira Filho on 2015-04-28
-
Update visuals.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:377
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 378. By Renato Araujo Oliveira Filho on 2015-04-29
-
Disable click outside the ok button while the swipe item demo is running.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:378
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 379. By Renato Araujo Oliveira Filho on 2015-04-29
-
Added missing svg file.
- 380. By Renato Araujo Oliveira Filho on 2015-04-29
-
Created auto pilot tests.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:380
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| Gustavo Pichorim Boiko (boiko) wrote : | # |
I think it would be a good idea to have the view fading in when appearing and fading out when dismissing.
- 381. By Renato Araujo Oliveira Filho on 2015-05-01
-
Created animations for the tutorial appear and desapear
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:381
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 382. By Renato Araujo Oliveira Filho on 2015-05-01
-
Added a fade out in the texts.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:382
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
Are there any related MPs required for this MP to build/function as expected?
- lp:~renatofilho/address-book-app/list-with-actions-animated
Is your branch in sync with latest trunk?
YES
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES
Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES
If you changed the UI, was the change specified/approved by design?
YES
If you changed UI labels, did you update the pot file?
NO, Will be updated in a diff MR
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
NO PACKAGE CHANGED
| Gustavo Pichorim Boiko (boiko) wrote : | # |
If I open the recents view without having any item on it, and then I receive a call (no need to answer the call, just let it show as missed), the demo is not displayed.
Can you fix that?
- 383. By Renato Araujo Oliveira Filho on 2015-05-06
-
Show swipe demo if receive a call while the recents is open.
- 384. By Renato Araujo Oliveira Filho on 2015-05-07
-
Fix autopilot.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:383
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:384
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 385. By Renato Araujo Oliveira Filho on 2015-05-07
-
Trunk merged.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:385
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| Gustavo Pichorim Boiko (boiko) wrote : | # |
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes
Did CI run pass? If not, please explain why.
No, but not related to the changes.
Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

FAILED: Continuous integration, rev:373 jenkins. qa.ubuntu. com/job/ dialer- app-ci/ 517/ jenkins. qa.ubuntu. com/job/ dialer- app-vivid- i386-ci/ 27 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1551 jenkins. qa.ubuntu. com/job/ generic- mediumtests- vivid/657 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1380 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1549 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1549/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 18384 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-vivid/ 523 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 773 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-amd64/ 773/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/dialer- app-ci/ 517/rebuild
http://