Merge lp:~renatofilho/dialer-app/fix-1511477 into lp:dialer-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 488
Merged at revision: 493
Proposed branch: lp:~renatofilho/dialer-app/fix-1511477
Merge into: lp:dialer-app
Diff against target: 25 lines (+7/-1)
1 file modified
src/qml/ContactsPage/ContactsPage.qml (+7/-1)
To merge this branch: bzr merge lp:~renatofilho/dialer-app/fix-1511477
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+277632@code.launchpad.net

Commit message

Make sure that the search field receives focus when contact list page is active and in search mode.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

Looks good. Works fine.

review: Approve
489. By Renato Araujo Oliveira Filho

Use back button icon istead of close while searching.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected?
NO

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGED

If you changed UI labels, did you update the pot file?
NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
NO PACKAGING CHANGED

490. By Renato Araujo Oliveira Filho

Trunk merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/ContactsPage/ContactsPage.qml'
2--- src/qml/ContactsPage/ContactsPage.qml 2015-09-07 15:40:45 +0000
3+++ src/qml/ContactsPage/ContactsPage.qml 2015-11-24 00:26:26 +0000
4@@ -102,7 +102,7 @@
5
6 name: "searching"
7 backAction: Action {
8- iconName: "close"
9+ iconName: "back"
10 text: i18n.tr("Cancel")
11 onTriggered: {
12 contactList.forceActiveFocus()
13@@ -192,6 +192,12 @@
14 }
15 }
16
17+ onActiveChanged: {
18+ if (active && (state === "searching")) {
19+ searchField.forceActiveFocus()
20+ }
21+ }
22+
23 KeyboardRectagle {
24 id: keyboardRect
25 }

Subscribers

People subscribed via source and target branches