lp:~renatofilho/compiz/compiz-lp1033531

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.8 at revision 3307

Daniel van Vugt: Approve on 2012-08-13

Sam Spilsbury: Approve on 2012-08-09

Diff: 296 lines (+221/-2)

8 files modified

plugins/expo/CMakeLists.txt (+5/-1)
plugins/expo/src/click_threshold/CMakeLists.txt (+33/-0)
plugins/expo/src/click_threshold/include/click-threshold.h (+38/-0)
plugins/expo/src/click_threshold/src/click-threshold.cpp (+39/-0)
plugins/expo/src/click_threshold/tests/CMakeLists.txt (+19/-0)
plugins/expo/src/click_threshold/tests/test-expo-click-threshold.cpp (+79/-0)
plugins/expo/src/expo.cpp (+7/-1)
plugins/expo/src/expo.h (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1033531: Single click inside the Workspace Switcher should always return to a workspace

Wishlist

Fix Released

Link a bug report

Related blueprints

3311. By Renato Araujo Oliveira Filho on 2012-08-10

Changed "clickMovementInThreshold" signature to use int instead of CompPoint.

3310. By Renato Araujo Oliveira Filho on 2012-08-10

Used lower case for reserved words in cmake files.

3309. By Renato Araujo Oliveira Filho on 2012-08-09

Created new file with ¨clickMovementInThreshold¨ function.
Created unit test for function ¨clickMovementInThreshold¨.

3308. By Renato Araujo Oliveira Filho on 2012-08-09

Declared DND_THRESHOLD as "static const unsigned int" instead of "define";

3307. By Renato Araujo Oliveira Filho on 2012-08-09

Implemented exit from expo screen with only one click.

3306. By Sam Spilsbury on 2012-08-08

Make valgrind shut up about some known "leaks" in python and glib.
Fix some leaks in the tests in the process.. Fixes: . Approved by Daniel van Vugt.

3305. By Andrea Azzarone on 2012-08-07

Always call terminate callbacks for key bindings. ATM we call just the first
callback. (LP: #960652). Fixes: https://bugs.launchpad.net/bugs/960652. Approved by Daniel van Vugt.

3304. By MC Return on 2012-08-06

Reduced the scope of the variable 'icccm_version', removed a break that can never be executed, added the variables 'frameType', 'frameState' and 'frameActions' to decor_quads_to_property in the #else branch in KWD::Switcher::updateWindowProperties () as well and simplified calc_button_size (decor_t *d) in cairo.c.. Fixes: https://bugs.launchpad.net/bugs/1030473. Approved by Daniel van Vugt.

3303. By madill on 2012-08-06

bug fix for minor bug 1033085
 Commands addon desripion typo Buning -> binding. Fixes: https://bugs.launchpad.net/bugs/1033085. Approved by MC Return, Omer Akram.

3302. By MC Return on 2012-08-03

Fixed various problems described in bug 1030473.
Optimized performance and style following suggestions reported by cppcheck:

1. Used !xxxx.empty() instead of xxxx.size(), because it can be faster. xxxx.size() can take linear time while xxxx.empty() is guaranteed to take constant time.

2. Defensive programming: Reordered array-out-of-bound condition checks such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed, because the index is checked first.. Fixes: . Approved by Daniel van Vugt, Sam Spilsbury.