Merge lp:~renatofilho/buteo-syncfw-qml/rename-uoa-service into lp:buteo-syncfw-qml

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Michael Sheldon
Approved revision: 6
Merged at revision: 6
Proposed branch: lp:~renatofilho/buteo-syncfw-qml/rename-uoa-service
Merge into: lp:buteo-syncfw-qml
Diff against target: 61 lines (+6/-6)
2 files modified
tests/qml/buteo-syncfw.py (+4/-4)
tests/qml/tst_ButeoSyncFW.qml (+2/-2)
To merge this branch: bzr merge lp:~renatofilho/buteo-syncfw-qml/rename-uoa-service
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+273541@code.launchpad.net

Commit message

Rename uoa contacts service to avoid conflict with old services.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected?
NO

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGE.

If you changed UI labels, did you update the pot file?
NO LABEL CHANGE.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
NO PACKAGE CHANGED

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/qml/buteo-syncfw.py'
2--- tests/qml/buteo-syncfw.py 2015-09-01 03:50:01 +0000
3+++ tests/qml/buteo-syncfw.py 2015-10-06 14:56:23 +0000
4@@ -35,7 +35,7 @@
5 """<?xml version=\"1.0\" encoding=\"UTF-8\"?>
6 <profile type=\"sync\" name=\"test-profile\">
7 <key value=\"45\" name=\"accountid\"/>
8- <key value=\"contacts\" name=\"category\"/>
9+ <key value=\"buteo-contacts\" name=\"category\"/>
10 <key value=\"google.Contacts-\" name=\"displayname\"/>
11 <key value=\"true\" name=\"enabled\"/>
12 <key value=\"true\" name=\"hidden\"/>
13@@ -58,7 +58,7 @@
14 """<?xml version=\"1.0\" encoding=\"UTF-8\"?>
15 <profile name=\"63807467\" type=\"sync\">
16 <key value=\"110\" name=\"accountid\"/>
17- <key value=\"contacts\" name=\"category\"/>
18+ <key value=\"buteo-contacts\" name=\"category\"/>
19 <key value=\"online\" name=\"destinationtype\"/>
20 <key value=\"google-contacts-renato.teste2@gmail.com\" name=\"displayname\"/>
21 <key value=\"true\" name=\"enabled\"/>
22@@ -81,7 +81,7 @@
23 </profile>""",
24 """<?xml version=\"1.0\" encoding=\"UTF-8\"?>
25 <profile type=\"sync\" name=\"template-profile\">
26- <key value=\"contacts\" name=\"category\"/>
27+ <key value=\"buteo-contacts\" name=\"category\"/>
28 <key value=\"false\" name=\"enabled\"/>
29 <schedule syncconfiguredtime=\"\" interval=\"0\" days=\"\" externalsync=\"true\" time=\"\" enabled=\"false\">
30 <rush interval=\"0\" days=\"\" externalsync=\"false\" begin=\"\" enabled=\"false\" end=\"\"/>
31@@ -105,7 +105,7 @@
32 def syncProfilesByKey(self, key, value):
33 print ("syncProfilesByKey:", key, value)
34 if key == 'category':
35- if value == 'contacts':
36+ if value == 'buteo-contacts':
37 return [ButeoSyncFw.PROFILES[0], ButeoSyncFw.PROFILES[2], ButeoSyncFw.PROFILES[3]]
38 if value == 'calendar':
39 return [ButeoSyncFw.PROFILES[1]]
40
41=== modified file 'tests/qml/tst_ButeoSyncFW.qml'
42--- tests/qml/tst_ButeoSyncFW.qml 2015-09-01 12:33:18 +0000
43+++ tests/qml/tst_ButeoSyncFW.qml 2015-10-06 14:56:23 +0000
44@@ -161,7 +161,7 @@
45
46 function test_sync_by_profile_by_category()
47 {
48- var profiles = buteoComponent.syncProfilesByCategory('contacts')
49+ var profiles = buteoComponent.syncProfilesByCategory('buteo-contacts')
50 compare(profiles.length, 2)
51 compare(profiles[0], '63807467')
52 compare(profiles[1], 'test-profile')
53@@ -173,7 +173,7 @@
54 spy.target = buteoComponent
55 spy.signalName = "syncStatus"
56
57- compare(buteoComponent.startSyncByCategory('contacts'), true)
58+ compare(buteoComponent.startSyncByCategory('buteo-contacts'), true)
59
60 // wait for two signals (since we have two contacts profiles)
61 tryCompare(spy, "count", 2)

Subscribers

People subscribed via source and target branches