address-book-service

Merge lp:~renatofilho/address-book-service/hint-max-count into lp:address-book-service

hint-max-count
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2015-09-09

Status:

Superseded

Proposed branch:

lp:~renatofilho/address-book-service/hint-max-count

Merge into:

lp:address-book-service

Diff against target:

252 lines (+144/-15)

4 files modified

contacts/contacts-service.cpp (+10/-5)
contacts/qcontact-backend.cpp (+8/-6)
tests/tst_tools/mock/mock-buteo.py (+5/-4)
tests/tst_tools/mock/mock-galera.py (+121/-0)

To merge this branch:

bzr merge lp:~renatofilho/address-book-service/hint-max-count

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gustavo Pichorim Boiko (community)		2015-09-09	Approve on 2015-10-13
PS Jenkins bot	continuous-integration		Approve on 2015-10-05
Review via email: mp+270544@code.launchpad.net

This proposal has been superseded by a proposal from 2015-10-15.

Commit message

Implemented 'maxCountHint' support for queries.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/374/rebuild

review: Needs Fixing (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-09

161. By Renato Araujo Oliveira Filho on 2015-09-09

Optimize query when using phone number.

Do a initial filter on contacts based on phone number used in the query.

162. By Renato Araujo Oliveira Filho on 2015-09-09

Use the last 7 number of the phone as key for the phone number index.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/376/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/378/rebuild

review: Needs Fixing (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-09

163. By Renato Araujo Oliveira Filho on 2015-09-09

Use 'QThreadPool' to filter threads in View class.

This will avoid several threads running at the same time.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/381/rebuild

review: Needs Fixing (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-09

164. By Renato Araujo Oliveira Filho on 2015-09-09: Optmize union filter with phoneNumber.
165. By Renato Araujo Oliveira Filho on 2015-09-09: Lock contact-mode for read-only instead of full lock.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/382/rebuild

review: Needs Fixing (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-10

166. By Renato Araujo Oliveira Filho on 2015-09-10: Removed debug messages.
Added optimizations for interserc filter with phone number.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-10:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/383/rebuild

review: Needs Fixing (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-10

167. By Renato Araujo Oliveira Filho on 2015-09-10: Update tests with the new DBUS API.
168. By Renato Araujo Oliveira Filho on 2015-09-10: Make sure to update contact map whe a contact change came from folks.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-10:

PASSED: Continuous integration, rev:167
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/384/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/68/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/68
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4109
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3353
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4106
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4106/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23209

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/384/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-10

169. By Renato Araujo Oliveira Filho on 2015-09-10: Typo fixed.
170. By Renato Araujo Oliveira Filho on 2015-09-10: Merged 'lp:~tiagosh/address-book-service/close-view-asynchronously'
171. By Renato Araujo Oliveira Filho on 2015-09-10: Fixed wrong merge.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-10:

FAILED: Continuous integration, rev:169
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/385/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/69
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/69/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/69
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4112/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4109/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/385/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-10:

PASSED: Continuous integration, rev:171
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/387/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/71
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/71/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/71
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4114
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3356
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4111
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4111/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23215

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/387/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-10

172. By Renato Araujo Oliveira Filho on 2015-09-10: Fixed contact service crash.
Fixed contact sort order while searching for contacts.
173. By Renato Araujo Oliveira Filho on 2015-09-10: Fixed test enviroment setup.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-10:

PASSED: Continuous integration, rev:172
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/389/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/73
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/73/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/73
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4118
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3359
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4115
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4115/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23219

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/389/rebuild

review: Approve (continuous-integration)

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2015-09-10:

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGED

If you changed UI labels, did you update the pot file?
NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
NO PACKAGE CHANGED

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-10:

PASSED: Continuous integration, rev:173
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/390/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/74
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/74/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/74
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4120
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3360
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4117
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4117/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23222

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/390/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-18

174. By Renato Araujo Oliveira Filho on 2015-09-18: Run tests using ctest and without thread.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-18:

PASSED: Continuous integration, rev:174
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/410/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/94
        deb: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/94/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/94
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4251
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3466
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4248
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4248/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/23475

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/410/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-28

175. By Renato Araujo Oliveira Filho on 2015-09-28: Set request fetch hint for sync "contacts" function.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-28:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/419/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-29

176. By Renato Araujo Oliveira Filho on 2015-09-29: Avoid emit serviceChanged twice on initialization.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-09-30:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/421/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-09-30

177. By Renato Araujo Oliveira Filho on 2015-09-30: Only accepts queries if service is ready.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-01:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/423/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-10-02

178. By Renato Araujo Oliveira Filho on 2015-10-02: Trunk merged.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-02:

FAILED: Continuous integration, rev:178
http://jenkins.qa.ubuntu.com/job/address-book-service-ci/424/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-armhf-ci/108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/address-book-service-vivid-i386-ci/108/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4482/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4479/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/424/rebuild

review: Needs Fixing (continuous-integration)

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-10-05

179. By Renato Araujo Oliveira Filho on 2015-10-05: Export 'isReady' property on galera mock.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-05:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-service-ci/425/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2015-10-13:

Looks good and works as expected!

review: Approve

lp:~renatofilho/address-book-service/hint-max-count updated on 2015-10-15

180. By Renato Araujo Oliveira Filho on 2015-10-15: Trunk merged.
181. By Renato Araujo Oliveira Filho on 2015-10-15: Merged: ~renatofilho/address-book-service/fix-translation-pkg

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Renato Araujo Oliveira Filho

Ubuntu Phablet Team

 === modified file 'contacts/contacts-service.cpp'
 --- contacts/contacts-service.cpp	2015-09-18 14:58:37 +0000
 +++ contacts/contacts-service.cpp	2015-10-05 12:36:29 +0000
@@ -183,8 +183,11 @@
  void GaleraContactsService::onServiceReady()
+ {
--    m_serviceIsReady = m_iface.data()->property("isReady").toBool();
--    Q_EMIT serviceChanged();
++    bool isReady = m_iface.data()->property("isReady").toBool();
++    if (isReady != m_serviceIsReady) {
++        m_serviceIsReady = isReady;
++        Q_EMIT serviceChanged();
++    }
+ }
  void GaleraContactsService::initialize()
@@ -195,12 +198,14 @@
                                                                      CPIM_ADDRESSBOOK_IFACE_NAME));
          if (!m_iface->lastError().isValid()) {
              m_serviceIsReady = m_iface.data()->property("isReady").toBool();
--            connect(m_iface.data(), SIGNAL(readyChanged()), this, SLOT(onServiceReady()));
++            connect(m_iface.data(), SIGNAL(readyChanged()), this, SLOT(onServiceReady()), Qt::UniqueConnection);
              connect(m_iface.data(), SIGNAL(safeModeChanged()), this, SIGNAL(serviceChanged()));
              connect(m_iface.data(), SIGNAL(contactsAdded(QStringList)), this, SLOT(onContactsAdded(QStringList)));
              connect(m_iface.data(), SIGNAL(contactsRemoved(QStringList)), this, SLOT(onContactsRemoved(QStringList)));
              connect(m_iface.data(), SIGNAL(contactsUpdated(QStringList)), this, SLOT(onContactsUpdated(QStringList)));
--            Q_EMIT serviceChanged();
++            if (m_serviceIsReady) {
++                Q_EMIT serviceChanged();
++            }
          } else {
              qWarning() << "Fail to connect with service:"  << m_iface->lastError();
              m_iface.clear();
@@ -231,7 +236,7 @@
  bool GaleraContactsService::isOnline() const
+ {
--    return !m_iface.isNull();
++    return !m_iface.isNull() && m_serviceIsReady;
+ }
  void GaleraContactsService::fetchContactsById(QtContacts::QContactFetchByIdRequest *request)
 === modified file 'contacts/qcontact-backend.cpp'
 --- contacts/qcontact-backend.cpp	2015-09-16 15:57:58 +0000
 +++ contacts/qcontact-backend.cpp	2015-10-05 12:36:29 +0000
@@ -78,7 +78,7 @@
      connect(m_service, SIGNAL(contactsAdded(QList<QContactId>)), this, SIGNAL(contactsAdded(QList<QContactId>)));
      connect(m_service, SIGNAL(contactsRemoved(QList<QContactId>)), this, SIGNAL(contactsRemoved(QList<QContactId>)));
      connect(m_service, SIGNAL(contactsUpdated(QList<QContactId>)), this, SIGNAL(contactsChanged(QList<QContactId>)));
--    connect(m_service, SIGNAL(serviceChanged()), this, SIGNAL(dataChanged()));
++    connect(m_service, SIGNAL(serviceChanged()), this, SIGNAL(dataChanged()), Qt::QueuedConnection);
+ }
  /*! Frees any memory used by this engine */
@@ -121,14 +121,13 @@
  QList<QtContacts::QContact> GaleraManagerEngine::contacts(const QtContacts::QContactFilter &filter,
                                                            const QList<QtContacts::QContactSortOrder>& sortOrders,
--                                                          const QContactFetchHint &fetchHint, QtContacts::QContactManager::Error *error) const
++                                                          const QContactFetchHint &fetchHint,
++                                                          QtContacts::QContactManager::Error *error) const
+ {
--    Q_UNUSED(fetchHint);
--    Q_UNUSED(error);
--
      QContactFetchRequest request;
      request.setFilter(filter);
      request.setSorting(sortOrders);
++    request.setFetchHint(fetchHint);
      const_cast<GaleraManagerEngine*>(this)->startRequest(&request);
      const_cast<GaleraManagerEngine*>(this)->waitForRequestFinished(&request, -1);
@@ -140,7 +139,10 @@
      return request.contacts();
+ }
--QList<QContact> GaleraManagerEngine::contacts(const QList<QContactId> &contactIds, const QContactFetchHint &fetchHint, QMap<int, QContactManager::Error> *errorMap, QContactManager::Error *error) const
++QList<QContact> GaleraManagerEngine::contacts(const QList<QContactId> &contactIds,
++                                              const QContactFetchHint &fetchHint,
++                                              QMap<int, QContactManager::Error> *errorMap,
++                                              QContactManager::Error *error) const
+ {
      QContactFetchByIdRequest request;
      request.setIds(contactIds);
 === modified file 'tests/tst_tools/mock/mock-buteo.py'
 --- tests/tst_tools/mock/mock-buteo.py	2015-09-29 14:19:23 +0000
 +++ tests/tst_tools/mock/mock-buteo.py	2015-10-05 12:36:29 +0000
@@ -60,6 +60,11 @@
          return profileName
      @dbus.service.method(dbus_interface=MAIN_IFACE,
++                         out_signature='as')
++    def runningSyncs(self):
++        return []
++
++    @dbus.service.method(dbus_interface=MAIN_IFACE,
                           in_signature='ss', out_signature='as')
      def syncProfilesByKey(self, key, value):
          if key == "accountid" and (value in self._profiles):
@@ -85,10 +90,6 @@
      def signalProfileChanged(self, profileId, status, changedProfile):
          print("profileChanged called")
--    @dbus.service.signal(dbus_interface=MAIN_IFACE)
--    def safeModeChanged(self):
--        print("safeModeChanged called")
--
      def _run(self):
          self._mainloop.run()
 === modified file 'tests/tst_tools/mock/mock-galera.py'
 --- tests/tst_tools/mock/mock-galera.py	2015-09-29 14:19:23 +0000
 +++ tests/tst_tools/mock/mock-galera.py	2015-10-05 12:36:29 +0000
@@ -52,6 +52,7 @@
          dbus.service.Object.__init__(self, dbus.SessionBus(), object_path)
          self._mainloop = GObject.MainLoop()
          self._view = AddressBookView(VIEW_OBJ)
++        self._isReady = True
          self._sources = {}
      @dbus.service.method(dbus_interface=MAIN_IFACE,
@@ -111,6 +112,126 @@
      def contactsUpdated(self, contacts):
          print("contactsUpdated called")
++    @dbus.service.signal(dbus_interface=MAIN_IFACE)
++    def safeModeChanged(self):
++        print("safeModeChanged called")
++
++    @dbus.service.signal(dbus_interface=MAIN_IFACE)
++    def readyChanged(self):
++        print("readyChanged called")
++
++
++    #properties
++    @dbus.service.method(dbus_interface='org.freedesktop.DBus.Introspectable',
++                         out_signature='s')
++    def Introspect(self):
++        return """<!DOCTYPE node PUBLIC "-//freedesktop//DTD D-BUS Object Introspection 1.0//EN"
++    "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
++    <node name="/com/canonical/pim/AddressBook">
++      <interface name="com.canonical.pim.AddressBook">
++        <property name="isReady" type="b" access="read"/>
++        <signal name="readyChanged">
++        </signal>
++        <method name="reset">
++          <arg direction="out" type="b" />
++        </method>
++        <method name="availableSources">
++          <arg direction="out" type="a(ssssubb)" />
++        </method>
++        <signal name="safeModeChanged">
++        </signal>
++        <method name="query">
++          <arg direction="in"  type="s" name="clause" />
++          <arg direction="in"  type="s" name="sort" />
++          <arg direction="in"  type="i" name="max_count" />
++          <arg direction="in"  type="b" name="show_invisible" />
++          <arg direction="in"  type="as" name="sources" />
++          <arg direction="out" type="o" />
++        </method>
++        <method name="createSource">
++          <arg direction="in"  type="s" name="sourceId" />
++          <arg direction="in"  type="s" name="sourceName" />
++          <arg direction="in"  type="s" name="provider" />
++          <arg direction="in"  type="s" name="applicationId" />
++          <arg direction="in"  type="i" name="accountId" />
++          <arg direction="in"  type="b" name="readOnly" />
++          <arg direction="in"  type="b" name="primary" />
++          <arg direction="out" type="b" />
++        </method>
++        <signal name="contactsRemoved">
++          <arg type="as" name="contacts" />
++        </signal>
++        <method name="removeSource">
++          <arg direction="in"  type="s" name="sourceId" />
++          <arg direction="out" type="b" />
++        </method>
++        <signal name="contactsAdded">
++          <arg type="as" name="contacts" />
++        </signal>
++        <method name="removeContacts">
++          <arg direction="in"  type="as" name="contactIds" />
++          <arg direction="out" type="i" />
++        </method>
++        <signal name="contactsUpdated">
++          <arg type="as" name="contacts" />
++        </signal>
++      </interface>
++      <interface name="org.freedesktop.DBus.Introspectable">
++        <method name="Introspect">
++          <arg direction="out" type="s" />
++        </method>
++      </interface>
++      <interface name="org.freedesktop.DBus.Properties">
++        <method name="Set">
++          <arg direction="in"  type="s" name="interface_name" />
++          <arg direction="in"  type="s" name="property_name" />
++          <arg direction="in"  type="v" name="new_value" />
++        </method>
++        <signal name="PropertiesChanged">
++          <arg type="s" name="interface_name" />
++          <arg type="a{sv}" name="changed_properties" />
++          <arg type="as" name="invalidated_properties" />
++        </signal>
++        <method name="Get">
++          <arg direction="in"  type="s" name="interface_name" />
++          <arg direction="in"  type="s" name="property_name" />
++          <arg direction="out" type="v" />
++        </method>
++        <method name="GetAll">
++          <arg direction="in"  type="s" name="interface_name" />
++          <arg direction="out" type="a{sv}" />
++        </method>
++      </interface>
++    </node>
++    """
++
++    @dbus.service.method(dbus_interface=dbus.PROPERTIES_IFACE,
++                         in_signature='ss', out_signature='v')
++    def Get(self, interface_name, property_name):
++        return self.GetAll(interface_name)[property_name]
++
++    @dbus.service.method(dbus_interface=dbus.PROPERTIES_IFACE,
++                         in_signature='s', out_signature='a{sv}')
++    def GetAll(self, interface_name):
++        print("Get Property")
++        return {'isReady': True}
++
++    @dbus.service.method(dbus_interface=dbus.PROPERTIES_IFACE,
++                         in_signature='ssv')
++    def Set(self, interface_name, property_name, new_value):
++        # validate the property name and value, update internal state…
++        if property_name == 'isReady':
++            self._isReady = new_value
++            self.readyChanged()
++
++        self.PropertiesChanged(interface_name,
++            { property_name: new_value }, [])
++
++    @dbus.service.signal(dbus_interface=dbus.PROPERTIES_IFACE,
++                         signature='sa{sv}as')
++    def PropertiesChanged(self, interface_name, changed_properties,
++                          invalidated_properties):
++        pass
      #helper functions
      @dbus.service.method(dbus_interface=MAIN_IFACE,

address-book-service

Merge lp:~renatofilho/address-book-service/hint-max-count into lp:address-book-service

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers