Merge lp:~renatofilho/address-book-service/fix-1332124 into lp:address-book-service

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 126
Merged at revision: 126
Proposed branch: lp:~renatofilho/address-book-service/fix-1332124
Merge into: lp:address-book-service
Diff against target: 12 lines (+1/-1)
1 file modified
lib/detail-context-parser.cpp (+1/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-service/fix-1332124
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+226025@code.launchpad.net

Commit message

Used "cell" string to save mobile phones instead of "mobile". (Keep compatible with evolution)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? NO UI CHANGE

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGE

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/detail-context-parser.cpp'
2--- lib/detail-context-parser.cpp 2014-03-27 16:47:09 +0000
3+++ lib/detail-context-parser.cpp 2014-07-08 19:26:09 +0000
4@@ -96,7 +96,7 @@
5 // populate the map once
6 if (map.isEmpty()) {
7 map[QContactPhoneNumber::SubTypeLandline] = "landline";
8- map[QContactPhoneNumber::SubTypeMobile] = "mobile";
9+ map[QContactPhoneNumber::SubTypeMobile] = "cell";
10 map[QContactPhoneNumber::SubTypeFax] = "fax";
11 map[QContactPhoneNumber::SubTypePager] = "pager";
12 map[QContactPhoneNumber::SubTypeVoice] = "voice";

Subscribers

People subscribed via source and target branches