Merge lp:~renatofilho/address-book-service/fix-1193195 into lp:address-book-service

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 43
Merged at revision: 38
Proposed branch: lp:~renatofilho/address-book-service/fix-1193195
Merge into: lp:address-book-service
Prerequisite: lp:~renatofilho/address-book-service/missing-features
Diff against target: 63 lines (+3/-8)
2 files modified
common/vcard-parser.cpp (+2/-1)
src/qindividual.cpp (+1/-7)
To merge this branch: bzr merge lp:~renatofilho/address-book-service/fix-1193195
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+170996@code.launchpad.net

Commit message

Update server contact cache with the new contact info if update operation finish without error.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'common/vcard-parser.cpp'
2--- common/vcard-parser.cpp 2013-06-23 22:38:25 +0000
3+++ common/vcard-parser.cpp 2013-06-23 22:38:25 +0000
4@@ -81,7 +81,8 @@
5
6 virtual void contactProcessed(const QContact& contact, QVersitDocument* document)
7 {
8- //nothing
9+ Q_UNUSED(contact);
10+ document->removeProperties("X-QTPROJECT-EXTENDED-DETAIL");
11 }
12 };
13
14
15=== modified file 'src/qindividual.cpp'
16--- src/qindividual.cpp 2013-06-23 22:38:25 +0000
17+++ src/qindividual.cpp 2013-06-23 22:38:25 +0000
18@@ -285,7 +285,6 @@
19 qWarning() << "NO PERSONA";
20 return defaultPersona;
21 } else {
22-
23 GeeSet *personas = folks_individual_get_personas(individual);
24 QStringList index = uri.split(".");
25 Q_ASSERT(index.count() >= 1);
26@@ -1410,11 +1409,11 @@
27 }
28
29 if (data->m_details.isEmpty()) {
30+ data->m_self->m_contact = data->m_newContact;
31 updateDetailsSendReply(data, 0);
32 return;
33 }
34
35-
36 data->m_currentDetail = data->m_details.takeFirst();
37 switch(data->m_currentDetail.type()) {
38 case QContactDetail::TypeAddress:
39@@ -1501,7 +1500,6 @@
40 g_object_ref(m_individual);
41 }
42 // initialize qcontact
43- m_contact = QContact();
44 updateContact();
45 }
46 }
47@@ -1708,8 +1706,6 @@
48 {
49 static QMap<QString, int> map;
50
51- qDebug() << "PArse paramater:" << parameters;
52-
53 // populate the map once
54 if (map.isEmpty()) {
55 map["home"] = QContactDetail::ContextHome;
56@@ -1730,8 +1726,6 @@
57 parameters.removeOne(param);
58 }
59
60- qDebug() << "PArseed paramater (DONE):" << parameters;
61-
62 return values;
63 }
64

Subscribers

People subscribed via source and target branches