Merge lp:~renatofilho/address-book-app/vcard-does-not-export-uid into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 501
Merged at revision: 502
Proposed branch: lp:~renatofilho/address-book-app/vcard-does-not-export-uid
Merge into: lp:address-book-app
Diff against target: 15 lines (+4/-1)
1 file modified
src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml (+4/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/vcard-does-not-export-uid
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+277485@code.launchpad.net

Commit message

Does not export contact id.

Exporting contact id can cause problems if the user already contain a contact with the same id.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected?
NO

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGED

If you changed UI labels, did you update the pot file?
NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
NO PACKAGING CHANGED

502. By Renato Araujo Oliveira Filho

Trunk merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml'
2--- src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml 2015-10-28 01:09:58 +0000
3+++ src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml 2015-11-23 17:39:51 +0000
4@@ -79,7 +79,10 @@
5
6 property var busyDialog: null
7 property int currentQueryId: -1
8- readonly property var detailsBlackList: [ ContactDetail.Favorite, ContactDetail.Tag, ContactDetail.ExtendedDetail ]
9+ readonly property var detailsBlackList: [ ContactDetail.Favorite,
10+ ContactDetail.Tag,
11+ ContactDetail.ExtendedDetail,
12+ ContactDetail.Guid ]
13
14 function filterContactDetails(contact)
15 {

Subscribers

People subscribed via source and target branches