Merge lp:~renatofilho/address-book-app/update-autopilot-with-new-bottom-edge into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 493
Merged at revision: 493
Proposed branch: lp:~renatofilho/address-book-app/update-autopilot-with-new-bottom-edge
Merge into: lp:address-book-app
Diff against target: 59 lines (+31/-3)
3 files modified
tests/autopilot/address_book_app/__init__.py (+2/-1)
tests/autopilot/address_book_app/pages/__init__.py (+1/-2)
tests/autopilot/address_book_app/pages/_ab_contact_editor_page.py (+28/-0)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/update-autopilot-with-new-bottom-edge
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+275989@code.launchpad.net

Commit message

Updated autopilot tests, with the new ABContactEditorPage.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/address_book_app/__init__.py'
2--- tests/autopilot/address_book_app/__init__.py 2015-10-20 03:38:07 +0000
3+++ tests/autopilot/address_book_app/__init__.py 2015-10-28 13:29:20 +0000
4@@ -70,7 +70,8 @@
5 def get_contact_edit_page(self):
6 # We can have two contact editor page because of bottom edge page
7 # but we will return only the active one
8- return self.wait_select_single(objectName="contactEditorPage", active=True)
9+ return self.wait_select_single(pages.ABContactEditorPage,
10+ objectName="contactEditorPage", active=True)
11
12 def get_contact_view_page(self):
13 return self.wait_select_single(pages.ABContactViewPage,
14
15=== modified file 'tests/autopilot/address_book_app/pages/__init__.py'
16--- tests/autopilot/address_book_app/pages/__init__.py 2015-05-11 14:21:03 +0000
17+++ tests/autopilot/address_book_app/pages/__init__.py 2015-10-28 13:29:20 +0000
18@@ -20,7 +20,6 @@
19 'ABContactViewPage'
20 ]
21
22-from address_book_app.address_book \
23- import ContactEditorPage as ABContactEditorPage
24+from address_book_app.pages._ab_contact_editor_page import ABContactEditorPage
25 from address_book_app.pages._ab_contact_view_page import ABContactViewPage
26 from address_book_app.pages._ab_contact_list_page import ABContactListPage
27
28=== added file 'tests/autopilot/address_book_app/pages/_ab_contact_editor_page.py'
29--- tests/autopilot/address_book_app/pages/_ab_contact_editor_page.py 1970-01-01 00:00:00 +0000
30+++ tests/autopilot/address_book_app/pages/_ab_contact_editor_page.py 2015-10-28 13:29:20 +0000
31@@ -0,0 +1,28 @@
32+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
33+#
34+# Copyright (C) 2014 Canonical Ltd.
35+#
36+# This program is free software; you can redistribute it and/or modify
37+# it under the terms of the GNU General Public License version 3, as published
38+# by the Free Software Foundation.
39+#
40+# This program is distributed in the hope that it will be useful,
41+# but WITHOUT ANY WARRANTY; without even the implied warranty of
42+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
43+# GNU General Public License for more details.
44+#
45+# You should have received a copy of the GNU General Public License
46+# along with this program. If not, see <http://www.gnu.org/licenses/>.
47+
48+""" ContactEditorPage emulator for Addressbook App tests """
49+
50+import logging
51+import time
52+
53+import autopilot.logging
54+import ubuntuuitoolkit
55+
56+from address_book_app import address_book
57+
58+class ABContactEditorPage(address_book.ContactEditorPage):
59+ """Autopilot helper for the Contact Editor page."""

Subscribers

People subscribed via source and target branches