Merge lp:~renatofilho/address-book-app/rename-contacts-service into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Rejected
Rejected by: Renato Araujo Oliveira Filho
Proposed branch: lp:~renatofilho/address-book-app/rename-contacts-service
Merge into: lp:address-book-app
Diff against target: 25 lines (+3/-3)
1 file modified
src/imports/Ubuntu/Contacts/ContactListView.qml (+3/-3)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/rename-contacts-service
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+273540@code.launchpad.net

Commit message

Renamed from 'contacts' service to 'buteo-contacts'.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

483. By Renato Araujo Oliveira Filho

Renamed from 'contacts' service to 'buteo-contacts'.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/Contacts/ContactListView.qml'
2--- src/imports/Ubuntu/Contacts/ContactListView.qml 2015-09-18 13:18:40 +0000
3+++ src/imports/Ubuntu/Contacts/ContactListView.qml 2015-10-06 14:50:34 +0000
4@@ -214,10 +214,10 @@
5 */
6 // we are using 'buteoSync.visibleSyncProfiles because' it is a property
7 // and will re-check if the property changes.
8- // Using only '(buteoSync.syncProfilesByCategory("contacts").length > 0)'
9+ // Using only '(buteoSync.syncProfilesByCategory(""buteo-contacts").length > 0)'
10 // the value will be checked only on app startup
11 readonly property bool syncEnabled: (buteoSync.profilesCount > 0) &&
12- (buteoSync.syncProfilesByCategory("contacts").length > 0)
13+ (buteoSync.syncProfilesByCategory("buteo-contacts").length > 0)
14 /*!
15 \qmlproperty bool busy
16
17@@ -349,7 +349,7 @@
18 */
19 function sync()
20 {
21- buteoSync.startSyncByCategory("contacts")
22+ buteoSync.startSyncByCategory("buteo-contacts")
23 }
24
25 ContactSimpleListView {

Subscribers

People subscribed via source and target branches