Merge lp:~renatofilho/address-book-app/remove-contact-view-custom-back-action into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 551
Merged at revision: 558
Proposed branch: lp:~renatofilho/address-book-app/remove-contact-view-custom-back-action
Merge into: lp:address-book-app
Diff against target: 28 lines (+0/-18)
1 file modified
src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml (+0/-18)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/remove-contact-view-custom-back-action
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+287791@code.launchpad.net

Commit message

Remove custom back button from contact view.

This is not necessary, AdaptiveLayout will take care of it.

To post a comment you must log in.
551. By Renato Araujo Oliveira Filho

Remove custom back button from contact view.

This is not necessary, AdaptiveLayout will take care of it.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml'
2--- src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml 2016-02-24 23:06:48 +0000
3+++ src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml 2016-03-02 14:41:52 +0000
4@@ -50,24 +50,6 @@
5 trailingActionBar {
6 id: trailingBar
7 }
8- leadingActionBar {
9- id: leadingBar
10- actions: Action {
11- id: backAction
12-
13- iconName: "back"
14- name: "cancel"
15- enabled: visible && root.active && root.enabled
16- visible: (pageStack.columns == 1) || (pageStack.columns == undefined)
17- onTriggered: {
18- if (pageStack.removePages)
19- pageStack.removePages(root)
20- else
21- pageStack.pop()
22- }
23- }
24-
25- }
26 }
27
28 Connections {

Subscribers

People subscribed via source and target branches