Merge lp:~renatofilho/address-book-app/release-2014-07-09 into lp:address-book-app
Proposed by
Renato Araujo Oliveira Filho
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tiago Salem Herrmann | ||||
Approved revision: | 215 | ||||
Merged at revision: | 234 | ||||
Proposed branch: | lp:~renatofilho/address-book-app/release-2014-07-09 | ||||
Merge into: | lp:address-book-app | ||||
Diff against target: |
218 lines (+55/-41) 6 files modified
click/manifest.json.in (+1/-1) debian/control (+2/-0) src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+8/-4) src/imports/ContactEdit/ValueSelector.qml (+2/-3) src/imports/Ubuntu/Contacts/ContactDetailPhoneNumberTypeModel.qml (+9/-4) src/imports/Ubuntu/Contacts/ContactListView.qml (+33/-29) |
||||
To merge this branch: | bzr merge lp:~renatofilho/address-book-app/release-2014-07-09 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tiago Salem Herrmann (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+226231@code.launchpad.net |
Commit message
* Show the "+" icon in contact editor mode if the image is empty.
* Fixed app crash wen starting the searching from favorite mode.
To post a comment you must log in.
Are there any related MPs required for this MP to build/function as expected? NO
Is your branch in sync with latest trunk? YES
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES
Did you successfully run all tests found in your component's Test Plan on device or emulator? YES
If you changed the UI, was the change specified/approved by design? NO UI CHANGE
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGE