Merge lp:~renatofilho/address-book-app/push-page-sync into lp:address-book-app

[Renato Araujo Oliveira Filho]

Load pages sync to avoid delays.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:493
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/993/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/296
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/4948
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/3972
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4945
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/4945/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24751

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/993/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/address-book-app/push-page-sync]

494. By Renato Araujo Oliveira Filho on 2015-11-05

trunk merged.

495. By Renato Araujo Oliveira Filho on 2015-11-05

Trunk merged.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:495
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/996/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/299
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5032
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/4040
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5029
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5029/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24954

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/996/rebuild

review: Approve (continuous-integration)

[Florian Boucault (fboucault)]

Code looks fine.

review: Approve

[Renato Araujo Oliveira Filho (renatofilho)]

Are there any related MPs required for this MP to build/function as expected?
NO

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGED

If you changed UI labels, did you update the pot file?
NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
NO PACKAGING CHANGED

[lp:~renatofilho/address-book-app/push-page-sync]

496. By Renato Araujo Oliveira Filho on 2015-11-24

Trunk merged.

=== modified file 'src/imports/ABContactListPage.qml'
--- src/imports/ABContactListPage.qml	2015-10-26 13:18:11 +0000
+++ src/imports/ABContactListPage.qml	2015-11-24 00:29:38 +0000
@@ -66,24 +66,18 @@
     }
 
     function openEditPage(editPageProperties, sourcePage) {
-        var incubator = pageStack.addPageToNextColumn(sourcePage,
-                                          Qt.resolvedUrl("ABContactEditorPage.qml"),
-                                          editPageProperties);
-        incubator.onStatusChanged = function(status) {
-            if (status == Component.Ready) {
-                mainPage.contactEditorPage = incubator.object;
-            }
+        var component = Qt.createComponent(Qt.resolvedUrl("ABContactEditorPage.qml"))
+        if (component.status === Component.Ready) {
+            mainPage.contactEditorPage = component.createObject(mainPage, editPageProperties)
+            pageStack.addPageToNextColumn(sourcePage, mainPage.contactEditorPage)
         }
     }
 
     function openViewPage(viewPageProperties) {
-        var incubator = pageStack.addPageToNextColumn(mainPage,
-                                      Qt.resolvedUrl("ABContactViewPage.qml"),
-                                      viewPageProperties);
-        incubator.onStatusChanged = function(status) {
-            if (status == Component.Ready) {
-                contactViewPage = incubator.object;
-            }
+        var component = Qt.createComponent(Qt.resolvedUrl("ABContactViewPage.qml"))
+        if (component.status === Component.Ready) {
+            mainPage.contactViewPage = component.createObject(mainPage, viewPageProperties)
+            pageStack.addPageToNextColumn(mainPage, mainPage.contactViewPage)
         }
     }