Merge lp:~renatofilho/address-book-app/fix-test_import_from_sim into lp:address-book-app
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gustavo Pichorim Boiko on 2015-05-13 | ||||
| Approved revision: | 427 | ||||
| Merged at revision: | 435 | ||||
| Proposed branch: | lp:~renatofilho/address-book-app/fix-test_import_from_sim | ||||
| Merge into: | lp:address-book-app | ||||
| Diff against target: |
40 lines (+8/-7) 2 files modified
tests/autopilot/address_book_app/pages/_contact_list_page.py (+6/-0) tests/autopilot/address_book_app/tests/test_import_from_sim.py (+2/-7) |
||||
| To merge this branch: | bzr merge lp:~renatofilho/address-book-app/fix-test_import_from_sim | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gustavo Pichorim Boiko (community) | Approve on 2015-05-13 | ||
| PS Jenkins bot | continuous-integration | 2015-05-12 | Approve on 2015-05-13 |
| Leo Arias | 2015-05-12 | Pending | |
| Omer Akram | 2015-05-12 | Pending | |
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-05-12.
Commit Message
Updated autopilot test:
Check if "import from sim button" is invisible when all SIM cards get removed.
| Omer Akram (om26er) wrote : | # |
Now that the test behavior have been changed, please change the test name to something like:
test_import_
| Omer Akram (om26er) wrote : | # |
Other than that code looks good to me.
| Leo Arias (elopio) wrote : | # |
Every failed test is an opportunity to clean up the test and make it more readable.
Take a look at:
https:/
In there, I removed the initial check because it has nothing to do with the name of the test. It should be tested elsewhere that when you open the app, no contacts are shown.
Also, I moved the selection to the page helper object. Every time you have a select single in the test body, there's something wrong. If we move them to the page object it will be easier to read and easier to maintain.
After the cleanup, it seems to me that this is a good candidate to be turned into a QML test. Here we are only checking that a button is not shown if certain conditions are not met. That's purely UI, it has nothing to do with a user story so autopilot seems like a tool too big and slow for it. Do you agree?
Finally, the name of the test still sounds wrong: test_import_
We are not checking that the item is disabled. We are checking that it is not visible.
| Leo Arias (elopio) wrote : | # |
ah, and this might conflicts with federico's flake8 branch:
https:/
It would be safer using that branch as a prerequisite.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:424
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:426
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:429
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:427
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:427
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Are there any related MPs required for this MP to build/function as expected?
NO
Is your branch in sync with latest trunk?
YES
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES
Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES
If you changed the UI, was the change specified/approved by design?
NO UI CHANGE
If you changed UI labels, did you update the pot file?
NO LABEL CHANGE
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
NO PACKAGE CHANGE
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:427
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:427
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Gustavo Pichorim Boiko (boiko) wrote : | # |
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes
Did CI run pass? If not, please explain why.
Yes
Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes
FAILED: Continuous integration, rev:423
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://