Merge lp:~renatofilho/address-book-app/fix-bad-url into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 466
Merged at revision: 495
Proposed branch: lp:~renatofilho/address-book-app/fix-bad-url
Merge into: lp:address-book-app
Prerequisite: lp:~renatofilho/address-book-app/update-autopilot-with-new-bottom-edge
Diff against target: 21 lines (+10/-1)
1 file modified
src/imports/ABContactViewPage.qml (+10/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-bad-url
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Approve
Michael Sheldon (community) Approve
Review via email: mp+275991@code.launchpad.net

This proposal supersedes a proposal from 2015-07-22.

Commit message

Ignore default actions on contact view.

Does not call url-dispatcher for "default" action.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote : Posted in a previous version of this proposal

Looks good :)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) :
review: Approve
Revision history for this message
Bill Filler (bfiller) wrote :

clicking phone number should always dial the number, but instead tries to send sms if you access contacts from the messaging-app

review: Needs Fixing
Revision history for this message
Bill Filler (bfiller) wrote :

on second thought, I think that is the correct behavior and is what iPhone does

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/ABContactViewPage.qml'
2--- src/imports/ABContactViewPage.qml 2015-10-26 13:18:11 +0000
3+++ src/imports/ABContactViewPage.qml 2015-10-28 13:49:06 +0000
4@@ -85,7 +85,16 @@
5 }
6 }
7
8- onActionTrigerred: Qt.openUrlExternally(("%1:%2").arg(action).arg(detail.value(0)))
9+ onActionTrigerred: {
10+ // "default" action is used inside of the apps (dialer, messaging) to trigger
11+ // actions based on context.
12+ // For example default action in the dialer app is call the contact number
13+ if (action == "default") {
14+ action = "tel";
15+ }
16+
17+ Qt.openUrlExternally(("%1:%2").arg(action).arg(detail.value(0)))
18+ }
19
20 Component {
21 id: contactShareComponent

Subscribers

People subscribed via source and target branches