Merge lp:~renatofilho/address-book-app/fix-autopilot-most-called into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Merged at revision: 220
Proposed branch: lp:~renatofilho/address-book-app/fix-autopilot-most-called
Merge into: lp:address-book-app
Diff against target: 30 lines (+8/-2)
2 files modified
src/imports/Ubuntu/Contacts/ContactListView.qml (+8/-1)
src/imports/Ubuntu/Contacts/MostCalledModel.qml (+0/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-autopilot-most-called
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+225222@code.launchpad.net

Commit message

Load frequently called contact only when the list became visible.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? NO UI CHANGE

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGE

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/Contacts/ContactListView.qml'
2--- src/imports/Ubuntu/Contacts/ContactListView.qml 2014-06-27 21:27:30 +0000
3+++ src/imports/Ubuntu/Contacts/ContactListView.qml 2014-07-01 18:50:02 +0000
4@@ -440,8 +440,15 @@
5
6 model: MostCalledModel {
7 id: calledModel
8+
9+ readonly property bool visible: view.favouritesIsSelected
10+
11+ onVisibleChanged: {
12+ if (visible) {
13+ filterEntries()
14+ }
15+ }
16 maxCount: 20
17-
18 onInfoRequested: root.infoRequested(contact)
19 onDetailClicked: root.detailClicked(contact, detail, action)
20 onAddContactClicked: root.addContactClicked(label)
21
22=== modified file 'src/imports/Ubuntu/Contacts/MostCalledModel.qml'
23--- src/imports/Ubuntu/Contacts/MostCalledModel.qml 2014-06-23 17:22:37 +0000
24+++ src/imports/Ubuntu/Contacts/MostCalledModel.qml 2014-07-01 18:50:02 +0000
25@@ -124,7 +124,6 @@
26 sortField: "timestamp"
27 sortOrder: HistorySort.DescendingOrder
28 }
29- Component.onCompleted: root.filterEntries()
30 }
31
32

Subscribers

People subscribed via source and target branches