Merge lp:~renatofilho/address-book-app/fix-1557722 into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 559
Merged at revision: 561
Proposed branch: lp:~renatofilho/address-book-app/fix-1557722
Merge into: lp:address-book-app
Diff against target: 46 lines (+4/-2)
4 files modified
data/address-book-app.desktop.in.in (+0/-1)
src/imports/ABContactListPage.qml (+1/-0)
src/imports/MainWindow.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactListView.qml (+2/-0)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1557722
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+289096@code.launchpad.net

Commit message

Allow the app to rotate.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
559. By Renato Araujo Oliveira Filho

Increased minimum size required for dual column to units.gu(90)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
560. By Renato Araujo Oliveira Filho

Fix empty state message alignment when on landscape mode.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/address-book-app.desktop.in.in'
2--- data/address-book-app.desktop.in.in 2016-02-11 17:32:04 +0000
3+++ data/address-book-app.desktop.in.in 2016-03-21 12:32:36 +0000
4@@ -13,5 +13,4 @@
5 X-Ubuntu-Touch=true
6 X-Ubuntu-Single-Instance=true
7 X-Ubuntu-Splash-Show-Header=true
8-X-Ubuntu-Supported-Orientations=portrait
9 @XSCREENSHOT@
10
11=== modified file 'src/imports/ABContactListPage.qml'
12--- src/imports/ABContactListPage.qml 2016-02-22 14:18:53 +0000
13+++ src/imports/ABContactListPage.qml 2016-03-21 12:32:36 +0000
14@@ -680,6 +680,7 @@
15
16 anchors {
17 verticalCenter: parent.verticalCenter
18+ verticalCenterOffset: contactList.headerItem ? contactList.headerItem.height / 2 : 0
19 left: parent.left
20 right: parent.right
21 leftMargin: units.gu(6)
22
23=== modified file 'src/imports/MainWindow.qml'
24--- src/imports/MainWindow.qml 2016-02-12 20:40:02 +0000
25+++ src/imports/MainWindow.qml 2016-03-21 12:32:36 +0000
26@@ -147,7 +147,7 @@
27 anchors.fill: parent
28 layouts: [
29 PageColumnsLayout {
30- when: mainStack.width >= units.gu(70)
31+ when: mainStack.width >= units.gu(90)
32 PageColumn {
33 maximumWidth: units.gu(50)
34 minimumWidth: units.gu(40)
35
36=== modified file 'src/imports/Ubuntu/Contacts/ContactListView.qml'
37--- src/imports/Ubuntu/Contacts/ContactListView.qml 2016-02-22 14:18:53 +0000
38+++ src/imports/Ubuntu/Contacts/ContactListView.qml 2016-03-21 12:32:36 +0000
39@@ -224,6 +224,8 @@
40 // the value will be checked only on app startup
41 readonly property bool syncEnabled: (buteoSync.profilesCount > 0) &&
42 (buteoSync.syncProfilesByCategory("contacts").length > 0)
43+
44+ property alias headerItem: view.headerItem
45 /*!
46 \qmlproperty bool busy
47

Subscribers

People subscribed via source and target branches