address-book-app

Merge lp:~renatofilho/address-book-app/fix-1555255 into lp:address-book-app

  1. fix-1555255
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Arthur Mello
Approved revision: 556
Merged at revision: 556
Proposed branch: lp:~renatofilho/address-book-app/fix-1555255
Merge into: lp:address-book-app
Diff against target: 21 lines (+2/-2)
1 file modified
src/imports/Settings/SettingsPage.qml (+2/-2)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1555255
Reviewer Review Type Date Requested Status
Arthur Mello (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+288562@code.launchpad.net

Commit message

Fix settings pages font color.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:556
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/1123/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/426
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6738
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/5108
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6749
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6749/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/28004

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/1123/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Arthur Mello (artmello) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Settings/SettingsPage.qml'
2--- src/imports/Settings/SettingsPage.qml 2016-02-22 14:18:53 +0000
3+++ src/imports/Settings/SettingsPage.qml 2016-03-09 19:34:38 +0000
4@@ -89,7 +89,7 @@
5 // FIXME: Using a private property here. This uses the old list item and the only way to change the text
6 // color is with this property.
7 // We should remove it when update the app to the new ListItem.
8- __foregroundColor: selected ? UbuntuColors.blue : Theme.palette.normal.foreground
9+ __foregroundColor: selected ? UbuntuColors.blue : Theme.palette.normal.baseText
10
11 Rectangle {
12 border {
13@@ -124,7 +124,7 @@
14 // FIXME: Using a private property here. This uses the old list item and the only way to change the text
15 // color is with this property.
16 // We should remove it when update the app to the new ListItem.
17- __foregroundColor: selected ? UbuntuColors.blue : Theme.palette.normal.foreground
18+ __foregroundColor: selected ? UbuntuColors.blue : Theme.palette.normal.baseText
19
20 Rectangle {
21 border {

Subscribers

People subscribed via source and target branches