Merge lp:~renatofilho/address-book-app/fix-1549362 into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 543
Merged at revision: 543
Proposed branch: lp:~renatofilho/address-book-app/fix-1549362
Merge into: lp:address-book-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml (+1/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1549362
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+287113@code.launchpad.net

Commit message

Make sure that the contact view back button still visible for apps that are not using AdaptivePageLayout.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml'
2--- src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml 2016-02-13 02:35:02 +0000
3+++ src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml 2016-02-24 23:07:55 +0000
4@@ -58,7 +58,7 @@
5 iconName: "back"
6 name: "cancel"
7 enabled: visible && root.active && root.enabled
8- visible: (pageStack.columns === 1)
9+ visible: (pageStack.columns == 1) || (pageStack.columns == undefined)
10 onTriggered: {
11 if (pageStack.removePages)
12 pageStack.removePages(root)

Subscribers

People subscribed via source and target branches