Merge lp:~renatofilho/address-book-app/fix-1510259 into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho on 2015-10-28
Status: Merged
Approved by: Michael Sheldon on 2015-10-28
Approved revision: 492
Merged at revision: 494
Proposed branch: lp:~renatofilho/address-book-app/fix-1510259
Merge into: lp:address-book-app
Prerequisite: lp:~renatofilho/address-book-app/update-autopilot-with-new-bottom-edge
Diff against target: 12 lines (+1/-1)
1 file modified
src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml (+1/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1510259
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration 2015-10-28 Approve on 2015-10-28
Michael Sheldon (community) 2015-10-28 Approve on 2015-10-28
Review via email: mp+275990@code.launchpad.net

This proposal supersedes a proposal from 2015-10-26.

Commit message

Does not export contact extend detail into vcard.

To post a comment you must log in.
Renato Araujo Oliveira Filho (renatofilho) wrote : Posted in a previous version of this proposal

Are there any related MPs required for this MP to build/function as expected?
NO

Is your branch in sync with latest trunk?
YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
YES

Did you successfully run all tests found in your component's Test Plan on device or emulator?
YES

If you changed the UI, was the change specified/approved by design?
NO UI CHANGED

If you changed UI labels, did you update the pot file?
NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
No PACKAGING CHANGED

Michael Sheldon (michael-sheldon) wrote : Posted in a previous version of this proposal

Looks good

review: Approve
492. By Renato Araujo Oliveira Filho on 2015-10-28

Merged fixes on autopilot: ~renatofilho/address-book-app/update-autopilot-with-new-bottom-edge

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml'
2--- src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml 2015-10-26 13:18:11 +0000
3+++ src/imports/Ubuntu/AddressBook/Base/ContactExporter.qml 2015-10-28 13:48:18 +0000
4@@ -79,7 +79,7 @@
5
6 property var busyDialog: null
7 property int currentQueryId: -1
8- readonly property var detailsBlackList: [ ContactDetail.Favorite, ContactDetail.Tag ]
9+ readonly property var detailsBlackList: [ ContactDetail.Favorite, ContactDetail.Tag, ContactDetail.ExtendedDetail ]
10
11 function filterContactDetails(contact)
12 {

Subscribers

People subscribed via source and target branches