Merge lp:~renatofilho/address-book-app/fix-1469005 into lp:address-book-app
Proposed by
Renato Araujo Oliveira Filho
Status: | Merged |
---|---|
Approved by: | Gustavo Pichorim Boiko |
Approved revision: | 486 |
Merged at revision: | 497 |
Proposed branch: | lp:~renatofilho/address-book-app/fix-1469005 |
Merge into: | lp:address-book-app |
Prerequisite: | lp:~renatofilho/address-book-app/update-autopilot-with-new-bottom-edge |
Diff against target: |
291 lines (+69/-45) 6 files modified
src/imports/Ubuntu/AddressBook/ContactEditor/AvatarImport.qml (+1/-4) src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailAvatarEditor.qml (+24/-3) src/imports/Ubuntu/Contacts/contacts.cpp (+10/-21) src/imports/Ubuntu/Contacts/contacts.h (+2/-1) src/imports/Ubuntu/Contacts/imagescalethread.cpp (+25/-11) src/imports/Ubuntu/Contacts/imagescalethread.h (+7/-5) |
To merge this branch: | bzr merge lp:~renatofilho/address-book-app/fix-1469005 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Pichorim Boiko (community) | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+276046@code.launchpad.net |
This proposal supersedes a proposal from 2015-10-19.
Commit message
Use Runnable implementation instead of thread to avoid overload cpu usage.
Implement async copyImage support.
To post a comment you must log in.
PASSED: Continuous integration, rev:484 jenkins. qa.ubuntu. com/job/ address- book-app- ci/963/ jenkins. qa.ubuntu. com/job/ address- book-app- vivid-i386- ci/266 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 4710 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 3803 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 4707 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 4707/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 24363
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/address- book-app- ci/963/ rebuild
http://