Merge lp:~renatofilho/address-book-app/fix-1426359 into lp:address-book-app

[Renato Araujo Oliveira Filho]

Fixed favorite list scroll to the first item.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:392
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/757/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/60
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1583
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/663
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1404
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1581
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1581/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18434
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/528
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/780
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/780/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/757/rebuild

review: Approve (continuous-integration)

[lp:~renatofilho/address-book-app/fix-1426359]

393. By Renato Araujo Oliveira Filho on 2015-04-01

Trunk merged.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:393
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/790/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/93
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2092
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/777/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1841
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2090
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2090/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19362
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/619/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/920
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/920/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/790/rebuild

review: Needs Fixing (continuous-integration)

[lp:~renatofilho/address-book-app/fix-1426359]

394. By Renato Araujo Oliveira Filho on 2015-04-02

Reduce the most called list size to 5 entries.

395. By Renato Araujo Oliveira Filho on 2015-04-02

Fixed most called model to show the correct number of contacts based on maxCount property.

396. By Renato Araujo Oliveira Filho on 2015-04-02

Use contactListView.positionViewAtIndex to fix first favorite item visiblity.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:396
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/791/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/94
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2112
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/780
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1859
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2110
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2110/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19397
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/622
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/924
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/924/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/791/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'src/imports/Ubuntu/Contacts/ContactSimpleListView.qml'
--- src/imports/Ubuntu/Contacts/ContactSimpleListView.qml	2015-03-17 17:14:09 +0000
+++ src/imports/Ubuntu/Contacts/ContactSimpleListView.qml	2015-04-02 17:17:18 +0000
@@ -337,8 +337,11 @@
                 return
             // check if we should expand and display the details picker
             } else if (detailToPick !== -1) {
-                //view.highlightFollowsCurrentItem = true
                 contactListView.currentIndex = index
+                if (index == 0) {
+                    // WORKAROUND: Due the header the ListView does the wrong scolling for the first item
+                    contactListView.positionViewAtIndex(0, ListView.Beginning)
+                }
                 return
             } else if (detailToPick == -1) {
                 contactListView.detailClicked(contact, null, "")

=== modified file 'src/imports/Ubuntu/Contacts/MostCalledModel.qml'
--- src/imports/Ubuntu/Contacts/MostCalledModel.qml	2014-10-14 15:57:09 +0000
+++ src/imports/Ubuntu/Contacts/MostCalledModel.qml	2015-04-02 17:17:18 +0000
@@ -58,6 +58,7 @@
         id: mostCalledModel
 
         startInterval: new Date((new Date().getTime() - 2592000000)) // one month ago
+        maxCount: 5
         onLoaded: root.loaded()
         sourceModel: historyEventModel
     }

=== modified file 'src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp'
--- src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp	2014-09-05 02:22:31 +0000
+++ src/imports/Ubuntu/Contacts/mostcalledproxymodel.cpp	2015-04-02 17:17:18 +0000
@@ -337,7 +337,7 @@
             if (d.callCount >= m_average) {
                 m_data << d;
             }
-            if ((uint) m_data.size() > m_maxCount) {
+            if ((uint) m_data.size() >= m_maxCount) {
                 break;
             }
         }