Merge lp:~renatofilho/address-book-app/fix-1411323 into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 360
Merged at revision: 360
Proposed branch: lp:~renatofilho/address-book-app/fix-1411323
Merge into: lp:address-book-app
Diff against target: 12 lines (+1/-1)
1 file modified
src/imports/ContactList/ContactListPage.qml (+1/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1411323
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+246904@code.launchpad.net

Commit message

Use the "tick" icon to confirm button while in Pick mode.

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk? YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? YES

If you changed UI labels, did you update the pot file? NO LABEL CHANGED

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGED

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/ContactList/ContactListPage.qml'
2--- src/imports/ContactList/ContactListPage.qml 2014-12-11 18:45:20 +0000
3+++ src/imports/ContactList/ContactListPage.qml 2015-01-19 14:50:19 +0000
4@@ -423,7 +423,7 @@
5 Action {
6 objectName: "share"
7 text: i18n.tr("Share")
8- iconName: "share"
9+ iconName: mainPage.pickMode ? "tick" : "share"
10 enabled: (contactList.selectedItems.count > 0)
11 visible: contactList.isInSelectionMode
12 onTriggered: {

Subscribers

People subscribed via source and target branches