Merge lp:~renatofilho/address-book-app/fix-1400468 into lp:address-book-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 345
Merged at revision: 345
Proposed branch: lp:~renatofilho/address-book-app/fix-1400468
Merge into: lp:address-book-app
Diff against target: 19 lines (+1/-8)
1 file modified
src/imports/Ubuntu/Contacts/ContactListModel.qml (+1/-8)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1400468
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Pat McGowan (community) Approve
Review via email: mp+244048@code.launchpad.net

Commit message

Fix phone number search to find the search term in any position of the field value.

To post a comment you must log in.
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Tested and fixes the reported issue

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/Contacts/ContactListModel.qml'
2--- src/imports/Ubuntu/Contacts/ContactListModel.qml 2014-08-18 18:05:38 +0000
3+++ src/imports/Ubuntu/Contacts/ContactListModel.qml 2014-12-08 20:05:38 +0000
4@@ -78,14 +78,7 @@
5 detail: ContactDetail.PhoneNumber
6 field: PhoneNumber.Number
7 value: contactTermFilter.value
8- matchFlags: DetailFilter.MatchPhoneNumber
9- }
10-
11- DetailFilter {
12- detail: ContactDetail.PhoneNumber
13- field: PhoneNumber.Number
14- value: contactTermFilter.value
15- matchFlags: DetailFilter.MatchContains
16+ matchFlags: DetailFilter.MatchPhoneNumber | DetailFilter.MatchContains
17 }
18 },
19 IntersectionFilter {

Subscribers

People subscribed via source and target branches