Merge lp:~renatofilho/address-book-app/fix-1384707 into lp:address-book-app/rtm-14.09

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 317
Merged at revision: 285
Proposed branch: lp:~renatofilho/address-book-app/fix-1384707
Merge into: lp:address-book-app/rtm-14.09
Diff against target: 29 lines (+9/-2)
1 file modified
src/app/addressbookapp.cpp (+9/-2)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1384707
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
Review via email: mp+240330@code.launchpad.net

Commit message

Call "attach" on sync monitor server to notify a new client connection.
We need to notify sync-monitor that we are attached to him to start to receive signals.

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Are there any related MPs required for this MP to build/function as expected? NO

Is your branch in sync with latest trunk. YES

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES

Did you successfully run all tests found in your component's Test Plan on device or emulator? YES

If you changed the UI, was the change specified/approved by design? NO UI CHANGE

If you changed UI labels, did you update the pot file? NO LABEL CHANGE

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP? NO PACKAGE CHANGE

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/addressbookapp.cpp'
2--- src/app/addressbookapp.cpp 2014-07-20 20:23:20 +0000
3+++ src/app/addressbookapp.cpp 2014-10-31 20:09:53 +0000
4@@ -221,6 +221,11 @@
5 {
6 unsetFirstRun();
7
8+ if (m_syncMonitor) {
9+ m_syncMonitor->call("detach");
10+ delete m_syncMonitor;
11+ }
12+
13 if (m_view) {
14 delete m_view;
15 }
16@@ -438,9 +443,11 @@
17 "com.canonical.SyncMonitor");
18 if (m_syncMonitor->lastError().isValid()) {
19 qWarning() << "Fail to connect with sync monitor:" << m_syncMonitor->lastError();
20+ } else {
21+ connect(m_syncMonitor, SIGNAL(stateChanged()), SIGNAL(syncingChanged()));
22+ connect(m_syncMonitor, SIGNAL(enabledServicesChanged()), SIGNAL(syncEnabledChanged()));
23+ m_syncMonitor->call("attach");
24 }
25- connect(m_syncMonitor, SIGNAL(stateChanged()), SIGNAL(syncingChanged()));
26- connect(m_syncMonitor, SIGNAL(enabledServicesChanged()), SIGNAL(syncEnabledChanged()));
27 Q_EMIT syncEnabledChanged();
28 Q_EMIT syncingChanged();
29 }

Subscribers

People subscribed via source and target branches