Merge lp:~renatofilho/address-book-app/fix-1377334 into lp:~phablet-team/address-book-app/staging
Proposed by
Renato Araujo Oliveira Filho
Status: | Rejected |
---|---|
Rejected by: | Renato Araujo Oliveira Filho |
Proposed branch: | lp:~renatofilho/address-book-app/fix-1377334 |
Merge into: | lp:~phablet-team/address-book-app/staging |
Diff against target: |
380 lines (+142/-128) 4 files modified
src/imports/ContactEdit/AvatarImport.qml (+96/-91) src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+14/-17) src/imports/ContactList/ContactExporter.qml (+28/-2) src/imports/ContactList/ContactListPage.qml (+4/-18) |
To merge this branch: | bzr merge lp:~renatofilho/address-book-app/fix-1377334 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ken VanDine | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+237480@code.launchpad.net |
Commit message
Implement AvatarImport as a Page.
Does not use dialog on content hub component, to avoid application to get stuck.
Handle operation aborted in pick mode.
To post a comment you must log in.
Unmerged revisions
- 315. By Renato Araujo Oliveira Filho
-
Fixed contact export.
- 314. By Renato Araujo Oliveira Filho
-
Implement AvatarImport as a Page.
Does not use dialogs on content hub component, to avoid application to get stuck.
Handle operation aborted in pick mode.
I haven't done a full review yet, but I would suggest perhaps it's worth talking about adding the title to ContentTransferHint rather than reimplementing it here. I worry about needing to maintain a copy of that code, and it seems like a nice feature for ContentTransfer Hint.