Merge lp:~renatofilho/address-book-app/fix-1375513 into lp:~phablet-team/address-book-app/staging

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 309
Merged at revision: 311
Proposed branch: lp:~renatofilho/address-book-app/fix-1375513
Merge into: lp:~phablet-team/address-book-app/staging
Diff against target: 28 lines (+3/-1)
1 file modified
src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml (+3/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1375513
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+236522@code.launchpad.net

Commit message

Make bottom edge hint invisible when not active.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) :
review: Approve
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml'
2--- src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml 2014-09-18 13:27:28 +0000
3+++ src/imports/Ubuntu/Contacts/PageWithBottomEdge.qml 2014-09-30 14:11:24 +0000
4@@ -149,6 +149,7 @@
5 property bool hidden: (activeFocus === false) || ((bottomEdge.y - units.gu(1)) < tip.y)
6
7 enabled: mouseArea.enabled
8+ visible: page.bottomEdgeEnabled
9 anchors {
10 bottom: parent.bottom
11 horizontalCenter: bottomEdge.horizontalCenter
12@@ -221,6 +222,7 @@
13 maximumY: page.height
14 }
15 enabled: edgeLoader.status == Loader.Ready
16+ visible: page.bottomEdgeEnabled
17
18 anchors {
19 left: parent.left
20@@ -275,7 +277,7 @@
21 }
22 height: page.height
23 y: height
24- visible: page.bottomEdgeEnabled && !page.isCollapsed
25+ visible: !page.isCollapsed
26 state: "collapsed"
27 states: [
28 State {

Subscribers

People subscribed via source and target branches