Merge lp:~renatofilho/address-book-app/fix-1373196 into lp:~phablet-team/address-book-app/staging

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Bill Filler
Approved revision: 308
Merged at revision: 310
Proposed branch: lp:~renatofilho/address-book-app/fix-1373196
Merge into: lp:~phablet-team/address-book-app/staging
Diff against target: 34 lines (+5/-1)
2 files modified
src/imports/ContactEdit/ContactDetailAvatarEditor.qml (+3/-0)
src/imports/ContactEdit/ContactEditor.qml (+2/-1)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1373196
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+236326@code.launchpad.net

Commit message

[ContactEditor] disable save button while avatar scale still running

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/ContactEdit/ContactDetailAvatarEditor.qml'
2--- src/imports/ContactEdit/ContactDetailAvatarEditor.qml 2014-08-13 20:52:57 +0000
3+++ src/imports/ContactEdit/ContactDetailAvatarEditor.qml 2014-09-29 13:21:24 +0000
4@@ -23,6 +23,7 @@
5 ContactDetailBase {
6 id: root
7
8+ readonly property alias busy: activityIndicator.running
9 readonly property string defaultAvatar: "image://theme/add"
10
11 function isEmpty() {
12@@ -90,6 +91,8 @@
13 }
14
15 ActivityIndicator {
16+ id: activityIndicator
17+
18 anchors.centerIn: avatar
19 running: (avatarImport.importDialog != null)
20 visible: running
21
22=== modified file 'src/imports/ContactEdit/ContactEditor.qml'
23--- src/imports/ContactEdit/ContactEditor.qml 2014-09-03 19:09:15 +0000
24+++ src/imports/ContactEdit/ContactEditor.qml 2014-09-29 13:21:24 +0000
25@@ -409,7 +409,8 @@
26
27 iconName: "ok"
28 text: i18n.tr("Save")
29- enabled: !nameEditor.isEmpty() || !phonesEditor.isEmpty()
30+ // disable save button while avatar scale still running
31+ enabled: !avatarEditor.busy && (!nameEditor.isEmpty() || !phonesEditor.isEmpty())
32 onTriggered: contactEditor.save()
33 }
34 }

Subscribers

People subscribed via source and target branches