Merge lp:~renatofilho/address-book-app/fix-1331078 into lp:~phablet-team/address-book-app/staging

Proposed by Renato Araujo Oliveira Filho
Status: Work in progress
Proposed branch: lp:~renatofilho/address-book-app/fix-1331078
Merge into: lp:~phablet-team/address-book-app/staging
Diff against target: 17 lines (+2/-2)
1 file modified
src/imports/ContactList/ContactListPage.qml (+2/-2)
To merge this branch: bzr merge lp:~renatofilho/address-book-app/fix-1331078
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+223458@code.launchpad.net

Commit message

Removed use of ActivityIndicator in the contact list to reduce cpu usage.

Description of the change

We need to remove the ActivityIndicator due the bug https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1164919

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:189
http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-ci/150/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/961
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/868
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-amd64-ci/150
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/150
        deb: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-armhf-ci/150/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-team-address-book-app-staging-utopic-i386-ci/150
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1351
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1719
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/1719/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/8541
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/752
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1008
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1008/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-team-address-book-app-staging-ci/150/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Works well here. Tested on flo.

review: Approve

Unmerged revisions

189. By Renato Araujo Oliveira Filho

Removed use of ActivityIndicator in the contact list.

188. By Renato Araujo Oliveira Filho

Update contact view visuals.

Approved by Arthur Mello, PS Jenkins bot.

187. By Renato Araujo Oliveira Filho

Trunk branch merged.

186. By Renato Araujo Oliveira Filho

Export contacts model auto-update functionality.

185. By Renato Araujo Oliveira Filho

Implemented contact share.
Replaced ContentHub API with QML API.

184. By Renato Araujo Oliveira Filho

Removed ContactSearchListView component.
Moved ContactSimpleListView to the private API.
Added documentation for ContactListView properties.
Created "contactNameFilter" into ContactListView.

Approved by Tiago Salem Herrmann, PS Jenkins bot.

183. By Renato Araujo Oliveira Filho

Update app visuals.
Implemented fast scroll. Fixes: https://bugs.launchpad.net/bugs/1317445.

Approved by Gustavo Pichorim Boiko, PS Jenkins bot.

182. By Renato Araujo Oliveira Filho

Implemented contact search. Fixes: https://bugs.launchpad.net/bugs/1267248.

Approved by PS Jenkins bot, Tiago Salem Herrmann.

181. By Renato Araujo Oliveira Filho

Fixed click mode compilation.

180. By Leo Arias

Log autopilot warnings to a file temporary, because of bug 1327325. Fixes: https://bugs.launchpad.net/bugs/1327325.

Approved by PS Jenkins bot, Renato Araujo Oliveira Filho.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/ContactList/ContactListPage.qml'
2--- src/imports/ContactList/ContactListPage.qml 2014-06-16 12:59:54 +0000
3+++ src/imports/ContactList/ContactListPage.qml 2014-06-17 17:56:36 +0000
4@@ -218,11 +218,11 @@
5 (application.syncing && (contactList.count === 0)))
6
7
8- ActivityIndicator {
9+ Item {
10 id: activity
11
12 anchors.horizontalCenter: parent.horizontalCenter
13- running: indicator.visible
14+ //running: indicator.visible
15 }
16 Label {
17 anchors.horizontalCenter: activity.horizontalCenter

Subscribers

People subscribed via source and target branches