address-book-app

Merge lp:~renatofilho/address-book-app/fix-1277647 into lp:address-book-app

fix-1277647
Merge into trunk

Proposed by Renato Araujo Oliveira Filho on 2014-02-25

Status:

Merged

Merged at revision:

149

Proposed branch:

lp:~renatofilho/address-book-app/fix-1277647

Merge into:

lp:address-book-app

Diff against target:

23 lines (+5/-1)

1 file modified

src/imports/MainWindow.qml (+5/-1)

To merge this branch:

bzr merge lp:~renatofilho/address-book-app/fix-1277647

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Approve on 2014-03-14
Arthur Mello (community)		2014-02-25	Approve on 2014-02-25
Review via email: mp+208220@code.launchpad.net

Commit message

Avoid change the "Theme.name" during the component complete, this was causing a lot of properties binding loops.

Revision history for this message

Renato Araujo Oliveira Filho (renatofilho) wrote on 2014-02-25:

Are there any related MPs required for this MP to build/function as expected? NO
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes) YES
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator? YES
Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/address-book-app) on device or emulator? YES
If you changed the UI, was the change specified/approved by design? NO UI CHANGES
If you changed the packaging (debian), did you subscribe a core-dev to this MP? NO PACKAGE CHANGES

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-25:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/425/rebuild

review: Approve (continuous-integration)

Revision history for this message

Arthur Mello (artmello) wrote on 2014-02-25:

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/address-book-app) on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

review: Approve

lp:~renatofilho/address-book-app/fix-1277647 updated on 2014-02-28

140. By Renato Araujo Oliveira Filho on 2014-02-28: Merged mainline.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-02-28:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/442/rebuild

review: Approve (continuous-integration)

lp:~renatofilho/address-book-app/fix-1277647 updated on 2014-03-14

141. By Renato Araujo Oliveira Filho on 2014-03-14: Merged mainline.
142. By Renato Araujo Oliveira Filho on 2014-03-14: Updated change log with forced release.
143. By Renato Araujo Oliveira Filho on 2014-03-14: Reverted last commit.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/453/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-14:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/454/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Renato Araujo Oliveira Filho

Rufus

Ubuntu Phablet Team

1	=== modified file 'src/imports/MainWindow.qml'
2	--- src/imports/MainWindow.qml 2013-12-17 14:57:28 +0000
3	+++ src/imports/MainWindow.qml 2014-03-14 18:43:41 +0000
4	@@ -25,6 +25,11 @@
5	height: units.gu(71)
6	anchorToKeyboard: false
7
8	+ // workaround to change the application theme.
9	+ // Looks like SDK use this property to guess which theme to load.
10	+ // See bug #1277647
11	+ backgroundColor: "#221E1C"
12	+
13	signal applicationReady()
14
15	function contact(contactId) {
16	@@ -67,7 +72,6 @@
17	}
18
19	Component.onCompleted: {
20	- Theme.name = "Ubuntu.Components.Themes.SuruGradient"
21	mainStack.push(Qt.createComponent("ContactList/ContactListPage.qml"))
22	mainWindow.applicationReady()
23	}

address-book-app

Merge lp:~renatofilho/address-book-app/fix-1277647 into lp:address-book-app

Commit message

Description of the change

Preview Diff

Subscribers