Merge lp:~renatofilho/address-book-app/fix-1213975 into lp:address-book-app
Proposed by
Renato Araujo Oliveira Filho
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Bill Filler | ||||
Approved revision: | 86 | ||||
Merged at revision: | 82 | ||||
Proposed branch: | lp:~renatofilho/address-book-app/fix-1213975 | ||||
Merge into: | lp:address-book-app | ||||
Diff against target: |
237 lines (+103/-22) 5 files modified
src/imports/Common/ContactDetailBase.qml (+7/-0) src/imports/ContactEdit/ContactDetailGroupWithTypeEditor.qml (+1/-0) src/imports/ContactEdit/ContactDetailWithTypeEditor.qml (+7/-1) src/imports/ContactEdit/ValueSelector.qml (+67/-13) src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+21/-8) |
||||
To merge this branch: | bzr merge lp:~renatofilho/address-book-app/fix-1213975 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bill Filler (community) | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email:
|
Commit message
* Added a animation when closing the type selector.
* Force focus on InputField when clicking on the type selector.
* Highlight the editable item on contact edit page.
* Added a margin for field details.
To post a comment you must log in.
PASSED: Continuous integration, rev:85 jenkins. qa.ubuntu. com/job/ address- book-app- ci/181/ jenkins. qa.ubuntu. com/job/ address- book-app- saucy-amd64- ci/181 jenkins. qa.ubuntu. com/job/ address- book-app- saucy-armhf- ci/182 jenkins. qa.ubuntu. com/job/ address- book-app- saucy-armhf- ci/182/ artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ address- book-app- saucy-i386- ci/181 jenkins. qa.ubuntu. com/job/ generic- mediumtests- saucy/4084 jenkins. qa.ubuntu. com/job/ generic- mediumtests- touch/1710 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-saucy/ 392 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-i386/ 4193 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-i386/ 4193/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 1712 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- saucy-armhf/ 1712/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- maguro/ 1431 jenkins. qa.ubuntu. com/job/ generic- mediumtests- runner- mako/1443
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ address- book-app- ci/181/ rebuild
http://