Merge lp:~reldan/nova/lp776679 into lp:~hudson-openstack/nova/trunk

[Eldar Nugaev]

Removed path (predefined api version) from NOVA_URL

Removed path (predefined api version) from NOVA_URL.

[Dan Prince (dan-prince)]

Hi Edgar,

I'm a bit tentative about this.

Shouldn't it be up to the client (in this case nova-manage) to determine which API version it wants to communicate with?

Also how does this change effect the use of utilities like python-novaclient?

review: Needs Information

[Dan Prince (dan-prince)]

s/Edgar/Eldar/

Oops. I have an uncle named Edgar!

[Eldar Nugaev (reldan)]

Hi Dan :)

It's ok :)
At this moment in our libcloud based application for testing OS API we should cut protocol version from NOVA_URL and put needed protocol version. So we want to have such xml with information about allowed protocol versions or have a list with versions in novarc.

Eldar

[Eldar Nugaev (reldan)]

But I can offer other option. I may just add additional parameter - NOVA_PROTOCOLS_URL or something like that. What do you think about it?

[Devin Carlen (devcamcar)]

I don't see the need for this. If a client requires a specific version of an API, then it should manage that itself. I also don't see the need for an additional parameter. Can you explain your use case?

review: Disapprove

[Eldar Nugaev (reldan)]

Hi Devin.

I suppose we can't just drop this bug.
Nova gives response that v1.0 is DEPRECATED.
So I see inconsistency. I need link to information about versions and their status. At this time I have to get link to DEPRECATED (As we can see in nova) version, remove path from the link and change to CURRENT state.

version_objs = [
            {
                "id": "v1.1",
                "status": "CURRENT",
            },
            {
                "id": "v1.0",
                "status": "DEPRECATED",
            },
        ]

[Trey Morris (tr3buchet)]

Going to have to agree with Dan and Devin. The client should determine the version it uses, and further, I can't see a way to have nova determine the version instead without breaking all sorts of things each time we release a new version of the api.

review: Disapprove

[Brian Waldon (bcwaldon)]

Doesn't look like this is going to make it in, given there are two Disapproves.

[Soren Hansen (soren)]

> Shouldn't it be up to the client (in this case nova-manage) to determine which
> API version it wants to communicate with?

Isn't this exactly and argument *for* removing the version rather than keeping it?

[Brian Waldon (bcwaldon)]

Whew, only dead for 3 minutes!

So Eldar pointed out that v1.0 is DEPRECATED according to /versions. That isn't entirely accurate, as v1.1 is officially experimental. Should we fix this so v1.0 is labelled as our CURRENT version? We can also just bear with it knowing we are getting closer to v1.1 being complete.

So the real issue at hand: should we drop the version from the openstack api url in novarc? I would first like to ask for an explanation of what novarc is really intended to do. Is it just a catchall that has been collecting convenient information that us developers like having?

review: Needs Information

[Ilya Alekseyev (ilyaalekseyev)]

Gents,

I think that Soren comment is the most reasonable.

And just 2 cents about clients: if we provide to client NOVA_URL with api version, we are forcing client to use given API version. If in client will be some logic to manage API versions there should be some part of ugly code that removes api version from url.

Unmerged revisions

1053. By Eldar Nugaev on 2011-05-03

removed path from NOVA_URL

=== modified file 'nova/auth/manager.py'
--- nova/auth/manager.py	2011-04-30 02:31:29 +0000
+++ nova/auth/manager.py	2011-05-03 21:09:09 +0000
@@ -799,10 +799,9 @@
                                             FLAGS.ec2_port,
                                             FLAGS.ec2_path),
                    's3': 'http://%s:%s' % (s3_host, FLAGS.s3_port),
-                   'os': '%s://%s:%s%s' % (FLAGS.osapi_scheme,
-                                            ec2_host,
-                                            FLAGS.osapi_port,
-                                            FLAGS.osapi_path),
+                   'os': '%s://%s:%s' % (FLAGS.osapi_scheme,
+                                         ec2_host,
+                                         FLAGS.osapi_port),
                    'user': user.name,
                    'nova': FLAGS.ca_file,
                    'cert': FLAGS.credential_cert_file,