lp:kmod

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1998. By Rong Tao <email address hidden> on 2025-05-20

testsuite: modprobe: Add --force-{vermagic,modversion} tests

We don't have any moversion/vermagic tests. This patch add testsuite
--force-{vermagic,modversion} for modprobe.

Link: https://github.com/kmod-project/kmod/pull/344
Signed-off-by: Rong Tao <email address hidden>
Reviewed-by: Emil Velikov <email address hidden>
Signed-off-by: Lucas De Marchi <email address hidden>

1997. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: update remaining function to return the error code

Rework the function signature and return the error code instead of the
stripped module. Thus we no longer explicitly set errno.

v2:
 - kmod_file_open() - use _cleanup_free_, return errno instead of ENOMEM

Reference: https://github.com/kmod-project/kmod/issues/244
Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1996. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: return the errno from kmod_elf_new()

Rework the function signature and return the error code instead of the
stripped module. Thus we no longer explicitly set errno.

Reference: https://github.com/kmod-project/kmod/issues/244
Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1995. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: kmod_file_get_contents() returns constant data

The function returns what is considered constant data and all the
callers handle it as such. Add the declaration to make things obvious.

Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1994. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: enforce non-null memory in kmod_elf_new()

In practise none of our code-paths will use a NULL pointer so we might
as well enforce that. To stay aligned with the kernel behaviour update
our init_module() preload library to return EFAULT... Should we get
confused and pass NULL in the future.

Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1993. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: return the errno from kmod_elf_strip()

Rework the function signature and return the error code instead of the
stripped module. Thus we no longer explicitly set errno.

Reference: https://github.com/kmod-project/kmod/issues/244
Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1992. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: remove getdelim() buffer null check

As per the manual getdelim(3):
   The buffer is null-terminated and ...

Remove the local check and inline the function call. As a nice result,
we no longer set the errno and the context of feof() is obvious.

Reference: https://github.com/kmod-project/kmod/issues/244
Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1991. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: don't set errno in strbuf_to_vector()

The function does bounds checking, allocation and copying. In the first
instance, we manually set errno (to ENOMEM?) on failure. The realloc()
call does the same, implicitly.

In practice we don't distinguish between the two failures, so we might
as well stop manually setting errno and always assume ENOMEM in the
caller.

Reference: https://github.com/kmod-project/kmod/issues/244
Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1990. By Emil Velikov <email address hidden> on 2025-05-20

testsuite/init-module: error out init_module() on kmod failure

Currently our wrapper init_module() will happily return success whenever
libkmod fails. While such failures are unlikely, our wrapper should also
fail. In part so it doesn't mask a potentially deeper problem and in
part because the kmod API used, will set errno... Something a normal
syscall wouldn't do AFAICT.

v2:
 - remove the respective comment

Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>

1989. By Emil Velikov <email address hidden> on 2025-05-20

libkmod: return the errno from kmod_builtin_info_init()

Change the function signature (bool -> int) and directly return the
error code. Thus we no longer need to overwrite errno.

v2:
 - return false -> return -ENAMETOOLONG

Reference: https://github.com/kmod-project/kmod/issues/244
Signed-off-by: Emil Velikov <email address hidden>
Link: https://github.com/kmod-project/kmod/pull/346
Signed-off-by: Lucas De Marchi <email address hidden>