Merge lp:~reedobrien/charmworld/027test-fails into lp:charmworld

Proposed by Reed O'Brien
Status: Merged
Approved by: Reed O'Brien
Approved revision: 515
Merged at revision: 515
Proposed branch: lp:~reedobrien/charmworld/027test-fails
Merge into: lp:charmworld
Diff against target: 26 lines (+1/-4)
1 file modified
charmworld/migrations/versions/tests/test_migrations.py (+1/-4)
To merge this branch: bzr merge lp:~reedobrien/charmworld/027test-fails
Reviewer Review Type Date Requested Status
Juju Gui Bot continuous-integration Approve
Reed O'Brien (community) Approve
Review via email: mp+220499@code.launchpad.net

Commit message

Call wait_for_green_status() which will hopefully allow the test to pass on slower HW.

Description of the change

This will hopefully make the test pass on qa.

To post a comment you must log in.
Revision history for this message
Reed O'Brien (reedobrien) wrote :

one line change LGTM

review: Approve
Revision history for this message
Juju Gui Bot (juju-gui-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmworld/migrations/versions/tests/test_migrations.py'
2--- charmworld/migrations/versions/tests/test_migrations.py 2014-05-21 00:49:10 +0000
3+++ charmworld/migrations/versions/tests/test_migrations.py 2014-05-21 16:17:21 +0000
4@@ -161,6 +161,7 @@
5 self.index_client.delete_index()
6 # Create an empty index.
7 self.index_client._client.create_index(self.index_client.index_name)
8+ self.index_client.wait_for_green_status()
9 # Put up the old mappings.
10 for type_ in ('charm', 'bundle'):
11 self.index_client._client.put_mapping(
12@@ -183,14 +184,10 @@
13 self.assertEquals(self.data_store.current_version, self.version)
14 self.assertTrue(self.exists_in_index(charm['_id']))
15
16- # XXX: BradCrittenden 2014-05-20: On Jenkins this test is failing, likely
17- # due to an ill-configured ElasticSearch on the freshly minted
18- # environment. Skipping.
19 def test_exception_raised(self):
20 """Putting new mapping without creating the filter and analyzer
21 raises the expected exception.
22 """
23- self.skipTest("Fails on Jenkins. See kanban card.")
24 self.versions.ensure_initialized(self.data_store, True)
25 ## Pretend upgrades through 26 are complete.
26 self.data_store.update_version(26)

Subscribers

People subscribed via source and target branches

to all changes: